From 315c3da8a7d0bb92df17958d0be0be97f4e2c44b Mon Sep 17 00:00:00 2001 From: Sudarsana Nagineni Date: Mon, 24 Nov 2014 18:23:24 +0200 Subject: [PATCH] [Tizen] Fix error handling in system setting API This patch fixes error handling when system setting get/set property fails. --- system_setting/system_setting_api.js | 4 ++-- system_setting/system_setting_instance.cc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/system_setting/system_setting_api.js b/system_setting/system_setting_api.js index f6e65ae..58d327d 100644 --- a/system_setting/system_setting_api.js +++ b/system_setting/system_setting_api.js @@ -19,10 +19,10 @@ extension.setMessageListener(function(message) { delete m._reply_id; delete m._error; delete _callbacks[_reply_id]; - if (_error === 0) { + if (!_error) { handler[0](m._file); } else if (handler[1]) { - handler[1](new tizen.WebAPIError(_error)); + handler[1](new tizen.WebAPIError(tizen.WebAPIException.UNKNOWN_ERR)); } delete m._file; } else { diff --git a/system_setting/system_setting_instance.cc b/system_setting/system_setting_instance.cc index 4d8ee31..e2bca45 100644 --- a/system_setting/system_setting_instance.cc +++ b/system_setting/system_setting_instance.cc @@ -37,7 +37,7 @@ void SystemSettingInstance::OnPropertyHandled(const char* reply_id, o["_reply_id"] = picojson::value(reply_id); if (value) o["_file"] = picojson::value(value); - o["_error"] = picojson::value(static_cast(ret)); + o["_error"] = picojson::value(ret != 0); picojson::value v(o); PostMessage(v.serialize().c_str()); -- 2.7.4