From 315a1309defd8ddf910c6c17e28cbbd7faf92f2e Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Tue, 10 Feb 2015 11:17:53 +0100 Subject: [PATCH] coroutine: Fix use after free with qemu_coroutine_yield() Instead of using the same function for entering and exiting coroutines, and hoping that it doesn't add any functionality that hurts with the parameters used for exiting, we can just directly call into the real task switch in qemu_coroutine_switch(). This fixes a use-after-free scenario where reentering a coroutine that has yielded still accesses the old parent coroutine (which may have meanwhile terminated) in the part of coroutine_swap() that follows qemu_coroutine_switch(). Cc: qemu-stable@nongnu.org Signed-off-by: Kevin Wolf Reviewed-by: Paolo Bonzini --- qemu-coroutine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-coroutine.c b/qemu-coroutine.c index 525247b..5019b81 100644 --- a/qemu-coroutine.c +++ b/qemu-coroutine.c @@ -148,5 +148,5 @@ void coroutine_fn qemu_coroutine_yield(void) } self->caller = NULL; - coroutine_swap(self, to); + qemu_coroutine_switch(self, to, COROUTINE_YIELD); } -- 2.7.4