From 30959b20b9540a1b5bc4989759c45c51f3cb2e91 Mon Sep 17 00:00:00 2001 From: "ager@chromium.org" Date: Wed, 20 Oct 2010 08:52:46 +0000 Subject: [PATCH] Update x64 RecordWrite comment. When the offset is zero the index should be an untagged 32-bit integer on x64. There are debug mode asserts in the code that catch tagged integers so we get test failures if we get it wrong. Review URL: http://codereview.chromium.org/3928002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5668 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/x64/macro-assembler-x64.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/x64/macro-assembler-x64.h b/src/x64/macro-assembler-x64.h index 1bd3443..cb91067 100644 --- a/src/x64/macro-assembler-x64.h +++ b/src/x64/macro-assembler-x64.h @@ -101,9 +101,9 @@ class MacroAssembler: public Assembler { // dirty. |object| is the object being stored into, |value| is the // object being stored. If |offset| is zero, then the |scratch| // register contains the array index into the elements array - // represented as a Smi. All registers are clobbered by the - // operation. RecordWrite filters out smis so it does not update the - // write barrier if the value is a smi. + // represented as an untagged 32-bit integer. All registers are + // clobbered by the operation. RecordWrite filters out smis so it + // does not update the write barrier if the value is a smi. void RecordWrite(Register object, int offset, Register value, @@ -122,7 +122,7 @@ class MacroAssembler: public Assembler { // The value is known to not be a smi. // object is the object being stored into, value is the object being stored. // If offset is zero, then the scratch register contains the array index into - // the elements array represented as a Smi. + // the elements array represented as an untagged 32-bit integer. // All registers are clobbered by the operation. void RecordWriteNonSmi(Register object, int offset, -- 2.7.4