From 30079a5c8ae48e4bf7e9e9cc41682fd2aa61b4ec Mon Sep 17 00:00:00 2001
From: Parichay Kapoor <pk.kapoor@samsung.com>
Date: Mon, 1 Apr 2019 13:26:27 +0900
Subject: [PATCH] [IIO] Restriction on changing element properties

Element should be in state NULL or READY for the property of the device to be changed.
If the state is PAUSED/READY, properties cant be changed as the updated properties cannot
be reflected without the element going back to READY state.
Added freeing of properties before re-setting them.

Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
---
 gst/nnstreamer/tensor_source/tensor_src_iio.c | 33 ++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/gst/nnstreamer/tensor_source/tensor_src_iio.c b/gst/nnstreamer/tensor_source/tensor_src_iio.c
index 4c9d9df..da331b6 100644
--- a/gst/nnstreamer/tensor_source/tensor_src_iio.c
+++ b/gst/nnstreamer/tensor_source/tensor_src_iio.c
@@ -386,7 +386,7 @@ gst_tensor_src_iio_init (GstTensorSrcIIO * self)
   /** init properties */
   self->configured = FALSE;
   self->channels = DEFAULT_PROP_STRING;
-  self->mode = DEFAULT_OPERATING_MODE;
+  self->mode = g_strdup (DEFAULT_OPERATING_MODE);
   self->channels_enabled = CHANNELS_ENABLED_AUTO;
   gst_tensor_src_iio_device_properties_init (&self->trigger);
   gst_tensor_src_iio_device_properties_init (&self->device);
@@ -989,26 +989,57 @@ gst_tensor_src_iio_set_property (GObject * object, guint prop_id,
   GstTensorSrcIIO *self;
   self = GST_TENSOR_SRC_IIO (object);
 
+  GstStateChangeReturn status;
+  GstState state;
+
+  /**
+   * No support for setting properties in PAUSED/PLAYING state as it needs to
+   * reset the device. To change the properties, user should stop the pipeline
+   * and set element state to READY/NULL and then change the properties
+   */
+  status = gst_element_get_state (GST_ELEMENT (self), &state, NULL,
+      GST_CLOCK_TIME_NONE);
+  if (status == GST_STATE_CHANGE_FAILURE || status == GST_STATE_CHANGE_ASYNC
+      || state == GST_STATE_PLAYING || state == GST_STATE_PAUSED) {
+    GST_ERROR_OBJECT (self, "Can only set property in NULL or READY state.");
+    return;
+  }
+
   switch (prop_id) {
     case PROP_SILENT:
       self->silent = g_value_get_boolean (value);
       break;
 
     case PROP_MODE:
+    {
+      if (self->mode != NULL) {
+        g_free (self->mode);
+      }
       self->mode = g_value_dup_string (value);
       break;
+    }
 
     case PROP_DEVICE:
+    {
+      if (self->device.name != NULL) {
+        g_free (self->device.name);
+      }
       self->device.name = g_value_dup_string (value);
       break;
+    }
 
     case PROP_DEVICE_NUM:
       self->device.id = g_value_get_int (value);
       break;
 
     case PROP_TRIGGER:
+    {
+      if (self->trigger.name != NULL) {
+        g_free (self->trigger.name);
+      }
       self->trigger.name = g_value_dup_string (value);
       break;
+    }
 
     case PROP_TRIGGER_NUM:
       self->trigger.id = g_value_get_int (value);
-- 
2.7.4