From 2fa5c708f360865205bbfaf07a9f370613f30af9 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Sun, 28 Jul 2013 18:04:32 +0200 Subject: [PATCH] flacenc: Don't crash if there is no image tag information https://bugzilla.gnome.org/show_bug.cgi?id=705018 --- ext/flac/gstflacenc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ext/flac/gstflacenc.c b/ext/flac/gstflacenc.c index 3e6cd8a..ad136df 100644 --- a/ext/flac/gstflacenc.c +++ b/ext/flac/gstflacenc.c @@ -630,11 +630,15 @@ gst_flac_enc_set_metadata (GstFlacEnc * flacenc, GstAudioInfo * info, continue; } + structure = gst_sample_get_info (sample); + if (!structure) { + GST_ERROR_OBJECT (flacenc, "No image tag info"); + continue; + } + flacenc->meta[entries] = FLAC__metadata_object_new (FLAC__METADATA_TYPE_PICTURE); - structure = gst_sample_get_info (sample); - gst_structure_get (structure, "image-type", GST_TYPE_TAG_IMAGE_TYPE, &image_type, NULL); /* Convert to ID3v2 APIC image type */ -- 2.7.4