From 2f9ebc34d09fb8c3423e8ba8b4c0b4bf0d2462db Mon Sep 17 00:00:00 2001 From: "mstarzinger@chromium.org" Date: Wed, 30 Apr 2014 08:16:16 +0000 Subject: [PATCH] Remove duplicate ToObject implementaion from i18n. R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/255273004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21072 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/i18n.js | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/src/i18n.js b/src/i18n.js index 5819d2c..4fcb02b 100644 --- a/src/i18n.js +++ b/src/i18n.js @@ -279,7 +279,7 @@ function supportedLocalesOf(service, locales, options) { if (options === undefined) { options = {}; } else { - options = toObject(options); + options = ToObject(options); } var matcher = options.localeMatcher; @@ -513,18 +513,6 @@ function parseExtension(extension) { /** - * Converts parameter to an Object if possible. - */ -function toObject(value) { - if (IS_NULL_OR_UNDEFINED(value)) { - throw new $TypeError('Value cannot be converted to an Object.'); - } - - return $Object(value); -} - - -/** * Populates internalOptions object with boolean key-value pairs * from extensionMap and options. * Returns filtered extension (number and date format constructors use @@ -752,7 +740,7 @@ function initializeLocaleList(locales) { return freezeArray(seen); } - var o = toObject(locales); + var o = ToObject(locales); // Converts it to UInt32 (>>> is shr on 32bit integers). var len = o.length >>> 0; @@ -964,7 +952,7 @@ function initializeCollator(collator, locales, options) { return new Intl.Collator(locales, options); } - return initializeCollator(toObject(this), locales, options); + return initializeCollator(ToObject(this), locales, options); }, DONT_ENUM ); @@ -1191,7 +1179,7 @@ function initializeNumberFormat(numberFormat, locales, options) { return new Intl.NumberFormat(locales, options); } - return initializeNumberFormat(toObject(this), locales, options); + return initializeNumberFormat(ToObject(this), locales, options); }, DONT_ENUM ); @@ -1584,7 +1572,7 @@ function initializeDateTimeFormat(dateFormat, locales, options) { return new Intl.DateTimeFormat(locales, options); } - return initializeDateTimeFormat(toObject(this), locales, options); + return initializeDateTimeFormat(ToObject(this), locales, options); }, DONT_ENUM ); @@ -1790,7 +1778,7 @@ function initializeBreakIterator(iterator, locales, options) { return new Intl.v8BreakIterator(locales, options); } - return initializeBreakIterator(toObject(this), locales, options); + return initializeBreakIterator(ToObject(this), locales, options); }, DONT_ENUM ); -- 2.7.4