From 2f7806857a961c4c42d3e6e92956c11c20d83e7a Mon Sep 17 00:00:00 2001 From: Sasha Goldshtein Date: Thu, 9 Feb 2017 00:20:56 -0500 Subject: [PATCH] off{cpu,wake}time: Migrate to new symbols API and remove addresses Remove addresses from stack output, as these are not used in the vast majority of the cases. --- tools/offcputime.py | 4 ++-- tools/offwaketime.py | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/offcputime.py b/tools/offcputime.py index 1bab38b..9d3c847 100755 --- a/tools/offcputime.py +++ b/tools/offcputime.py @@ -271,11 +271,11 @@ for k, v in sorted(counts.items(), key=lambda counts: counts[1].value): else: # print default multi-line stack output for addr in kernel_stack: - print(" %016x %s" % (addr, b.ksym(addr))) + print(" %s" % b.ksym(addr)) if need_delimiter: print(" --") for addr in user_stack: - print(" %016x %s" % (addr, b.sym(addr, k.tgid))) + print(" %s" % b.sym(addr, k.tgid)) print(" %-16s %s (%d)" % ("-", k.name, k.pid)) print(" %d\n" % v.value) diff --git a/tools/offwaketime.py b/tools/offwaketime.py index 40d478b..5020fda 100644 --- a/tools/offwaketime.py +++ b/tools/offwaketime.py @@ -308,22 +308,22 @@ for k, v in sorted(counts.items(), key=lambda counts: counts[1].value): # print wakeup name then stack in reverse order print(" %-16s %s %s" % ("waker:", k.waker, k.t_pid)) for addr in waker_user_stack: - print(" %016x %s" % (addr, b.sym(addr, k.tgid))) + print(" %s" % b.sym(addr, k.tgid)) if args.delimited: print(" -") for addr in waker_kernel_stack: - print(" %016x %s" % (addr, b.ksym(addr))) + print(" %s" % b.ksym(addr)) # print waker/wakee delimiter print(" %-16s %s" % ("--", "--")) # print default multi-line stack output for addr in target_kernel_stack: - print(" %016x %s" % (addr, b.ksym(addr))) + print(" %s" % b.ksym(addr)) if args.delimited: print(" -") for addr in target_user_stack: - print(" %016x %s" % (addr, b.sym(addr, k.tgid))) + print(" %s" % b.sym(addr, k.tgid)) print(" %-16s %s %s" % ("target:", k.target, k.w_pid)) print(" %d\n" % v.value) -- 2.7.4