From 2f588aa809bc0d833626bfe36340be183511c6c9 Mon Sep 17 00:00:00 2001 From: Roman Marchenko Date: Tue, 21 Nov 2017 10:07:26 +0200 Subject: [PATCH] add excluding coverage comments for tdm_hwc_window.c add excluding coverage comments for tdm_hwc_window.c for folowing code: - fail if the backend's function don't exist; - dump; - calloc fail. Change-Id: I885ba709fd7407cd5ebb454fcf17f4487a646ad7 Signed-off-by: Roman Marchenko --- src/tdm_hwc_window.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/src/tdm_hwc_window.c b/src/tdm_hwc_window.c index 0fffd7d..3efe364 100644 --- a/src/tdm_hwc_window.c +++ b/src/tdm_hwc_window.c @@ -87,11 +87,13 @@ tdm_hwc_window_get_tbm_buffer_queue(tdm_hwc_window *hwc_window, tdm_error *error func_hwc_window = &private_display->func_hwc_window; if (!func_hwc_window->hwc_window_get_tbm_buffer_queue) { + /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); if (error) *error = TDM_ERROR_NOT_IMPLEMENTED; return NULL; + /* LCOV_EXCL_STOP */ } queue = func_hwc_window->hwc_window_get_tbm_buffer_queue(private_hwc_window->hwc_window_backend, error); @@ -113,9 +115,11 @@ tdm_hwc_window_set_zpos(tdm_hwc_window *hwc_window, uint32_t zpos) func_hwc_window = &private_display->func_hwc_window; if (!func_hwc_window->hwc_window_set_zpos) { + /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); return TDM_ERROR_NOT_IMPLEMENTED; + /* LCOV_EXCL_STOP */ } ret = func_hwc_window->hwc_window_set_zpos(private_hwc_window->hwc_window_backend, zpos); @@ -140,9 +144,11 @@ tdm_hwc_window_set_composition_type(tdm_hwc_window *hwc_window, func_hwc_window = &private_display->func_hwc_window; if (!func_hwc_window->hwc_window_set_composition_type) { + /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); return TDM_ERROR_NOT_IMPLEMENTED; + /* LCOV_EXCL_STOP */ } ret = func_hwc_window->hwc_window_set_composition_type(private_hwc_window->hwc_window_backend, composition_type); @@ -164,9 +170,11 @@ tdm_hwc_window_set_buffer_damage(tdm_hwc_window *hwc_window, tdm_hwc_region dama func_hwc_window = &private_display->func_hwc_window; if (!func_hwc_window->hwc_window_set_buffer_damage) { + /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); return TDM_ERROR_NOT_IMPLEMENTED; + /* LCOV_EXCL_STOP */ } ret = func_hwc_window->hwc_window_set_buffer_damage(private_hwc_window->hwc_window_backend, damage); @@ -192,9 +200,11 @@ tdm_hwc_window_set_info(tdm_hwc_window *hwc_window, tdm_hwc_window_info *info) func_hwc_window = &private_display->func_hwc_window; if (!func_hwc_window->hwc_window_set_info) { + /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); return TDM_ERROR_NOT_IMPLEMENTED; + /* LCOV_EXCL_STOP */ } if (info->src_config.format) @@ -218,6 +228,7 @@ tdm_hwc_window_set_info(tdm_hwc_window *hwc_window, tdm_hwc_window_info *info) return ret; } +/* LCOV_EXCL_START */ static void _tdm_window_dump_buffer(tdm_hwc_window *hwc_window, tbm_surface_h buffer) { @@ -237,6 +248,7 @@ _tdm_window_dump_buffer(tdm_hwc_window *hwc_window, tbm_surface_h buffer) return; } +/* LCOV_EXCL_STOP */ EXTERN tdm_error tdm_hwc_window_set_buffer(tdm_hwc_window *hwc_window, tbm_surface_h buffer) @@ -248,24 +260,30 @@ tdm_hwc_window_set_buffer(tdm_hwc_window *hwc_window, tbm_surface_h buffer) _pthread_mutex_lock(&private_display->lock); if ((tdm_debug_dump & TDM_DUMP_FLAG_WINDOW) && buffer) { + /* LCOV_EXCL_START */ char str[TDM_PATH_LEN]; static int i; snprintf(str, TDM_PATH_LEN, "window_%d_%d_%03d", private_output->index, private_hwc_window->zpos, i++); tdm_helper_dump_buffer_str(buffer, tdm_debug_dump_dir, str); + /* LCOV_EXCL_STOP */ } func_hwc_window = &private_display->func_hwc_window; if (!func_hwc_window->hwc_window_set_buffer) { + /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); return TDM_ERROR_NOT_IMPLEMENTED; + /* LCOV_EXCL_STOP */ } /* dump buffer */ + /* LCOV_EXCL_START */ if (tdm_dump_enable && buffer) _tdm_window_dump_buffer(hwc_window, buffer); + /* LCOV_EXCL_STOP */ ret = func_hwc_window->hwc_window_set_buffer(private_hwc_window->hwc_window_backend, buffer); @@ -287,9 +305,11 @@ tdm_hwc_window_create_internal(tdm_private_output *private_output, TDM_RETURN_VAL_IF_FAIL(TDM_MUTEX_IS_LOCKED(), NULL); if (!func_output->output_hwc_create_window) { + /* LCOV_EXCL_START */ if (error) *error = TDM_ERROR_BAD_MODULE; return NULL; + /* LCOV_EXCL_STOP */ } hwc_window_backend = func_output->output_hwc_create_window( @@ -302,11 +322,13 @@ tdm_hwc_window_create_internal(tdm_private_output *private_output, private_hwc_window = calloc(1, sizeof(tdm_private_capture)); if (!private_hwc_window) { + /* LCOV_EXCL_START */ TDM_ERR("failed: alloc memory"); func_output->output_hwc_destroy_window(private_output->output_backend, hwc_window_backend); if (error) *error = TDM_ERROR_OUT_OF_MEMORY; return NULL; + /* LCOV_EXCL_STOP */ } LIST_ADD(&private_hwc_window->link, &private_output->hwc_window_list); @@ -359,9 +381,11 @@ tdm_hwc_window_set_flags(tdm_hwc_window *hwc_window, tdm_hwc_window_flag flags) func_hwc_window = &private_display->func_hwc_window; if (!func_hwc_window->hwc_window_set_flags) { + /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); return TDM_ERROR_NOT_IMPLEMENTED; + /* LCOV_EXCL_STOP */ } ret = func_hwc_window->hwc_window_set_flags(private_hwc_window->hwc_window_backend, flags); @@ -383,9 +407,11 @@ tdm_hwc_window_unset_flags(tdm_hwc_window *hwc_window, tdm_hwc_window_flag flags func_hwc_window = &private_display->func_hwc_window; if (!func_hwc_window->hwc_window_unset_flags) { + /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); return TDM_ERROR_NOT_IMPLEMENTED; + /* LCOV_EXCL_STOP */ } ret = func_hwc_window->hwc_window_unset_flags(private_hwc_window->hwc_window_backend, flags); @@ -410,9 +436,11 @@ tdm_hwc_window_video_get_capability(tdm_hwc_window *hwc_window, func_hwc_window = &private_display->func_hwc_window; if (!func_hwc_window->hwc_window_video_get_capability) { + /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); return TDM_ERROR_NOT_IMPLEMENTED; + /* LCOV_EXCL_STOP */ } ret = func_hwc_window->hwc_window_video_get_capability(private_hwc_window->hwc_window_backend, @@ -440,9 +468,11 @@ tdm_hwc_window_video_get_supported_format(tdm_hwc_window *hwc_window, func_hwc_window = &private_display->func_hwc_window; if (!func_hwc_window->hwc_window_video_get_supported_format) { + /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); return TDM_ERROR_NOT_IMPLEMENTED; + /* LCOV_EXCL_STOP */ } ret = func_hwc_window->hwc_window_video_get_supported_format(private_hwc_window->hwc_window_backend, -- 2.7.4