From 2f4aeb2f53d96690953fabab487fd1d922f1c95f Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Mon, 11 May 2020 15:28:55 -0700 Subject: [PATCH] compiler: use const std::string& in a couple of places Use a reference to avoid copying a std::string. Fixes go/94766 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/233320 --- gcc/go/gofrontend/MERGE | 2 +- gcc/go/gofrontend/gogo.h | 4 ++-- gcc/go/gofrontend/names.cc | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index 5aecee1..428b329 100644 --- a/gcc/go/gofrontend/MERGE +++ b/gcc/go/gofrontend/MERGE @@ -1,4 +1,4 @@ -761d68dacefc578e45ff299761f20989aef67823 +41019d50ae519328dd3cf200815a2a2b0b64674e The first line of this file holds the git revision number of the last merge done from the gofrontend repository. diff --git a/gcc/go/gofrontend/gogo.h b/gcc/go/gofrontend/gogo.h index 7d83119..2fb8a3a 100644 --- a/gcc/go/gofrontend/gogo.h +++ b/gcc/go/gofrontend/gogo.h @@ -958,7 +958,7 @@ class Gogo // Return the name of the type descriptor list symbol of a package. std::string - type_descriptor_list_symbol(std::string); + type_descriptor_list_symbol(const std::string&); // Return the name of the list of all type descriptor lists. std::string @@ -1073,7 +1073,7 @@ class Gogo Specific_type_function(Type* atype, Named_type* aname, int64_t asize, Specific_type_function_kind akind, - const std::string afnname, + const std::string& afnname, Function_type* afntype) : type(atype), name(aname), size(asize), kind(akind), fnname(afnname), fntype(afntype) diff --git a/gcc/go/gofrontend/names.cc b/gcc/go/gofrontend/names.cc index f4ad181..a721a36 100644 --- a/gcc/go/gofrontend/names.cc +++ b/gcc/go/gofrontend/names.cc @@ -1024,7 +1024,7 @@ Gogo::type_descriptor_name(const Type* type, Named_type* nt) // Return the name of the type descriptor list symbol of a package. std::string -Gogo::type_descriptor_list_symbol(std::string pkgpath) +Gogo::type_descriptor_list_symbol(const std::string& pkgpath) { return pkgpath + "..types"; } -- 2.7.4