From 2f49ddeefe6d099a6a413061602aa1b31b0a08e6 Mon Sep 17 00:00:00 2001 From: peter klausler Date: Tue, 16 Jul 2019 15:45:00 -0700 Subject: [PATCH] [flang] review comment Original-commit: flang-compiler/f18@f5c46291ece846986c20dd1dbeeff433e0e20462 Reviewed-on: https://github.com/flang-compiler/f18/pull/580 --- flang/lib/semantics/resolve-names.cc | 2 +- flang/test/semantics/resolve20.f90 | 12 ++++++------ flang/test/semantics/resolve32.f90 | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/flang/lib/semantics/resolve-names.cc b/flang/lib/semantics/resolve-names.cc index 3e6bca3..6ddb12f 100644 --- a/flang/lib/semantics/resolve-names.cc +++ b/flang/lib/semantics/resolve-names.cc @@ -3941,7 +3941,7 @@ void DeclarationVisitor::CheckExplicitInterface(Symbol &symbol) { const Symbol *subp{FindSubprogram(*interface)}; if (subp == nullptr || !subp->HasExplicitInterface()) { Say(symbol.name(), - "The interface of '%s' (%s) is not an abstract interface or a " + "The interface of '%s' ('%s') is not an abstract interface or a " "procedure with an explicit interface"_err_en_US, symbol.name(), interface->name()); context().SetError(symbol); diff --git a/flang/test/semantics/resolve20.f90 b/flang/test/semantics/resolve20.f90 index 421f2f8..5e908e6 100644 --- a/flang/test/semantics/resolve20.f90 +++ b/flang/test/semantics/resolve20.f90 @@ -22,20 +22,20 @@ module m procedure(integer) :: b procedure(foo) :: c procedure(bar) :: d - !ERROR: The interface of 'e' (missing) is not an abstract interface or a procedure with an explicit interface + !ERROR: The interface of 'e' ('missing') is not an abstract interface or a procedure with an explicit interface procedure(missing) :: e - !ERROR: The interface of 'f' (b) is not an abstract interface or a procedure with an explicit interface + !ERROR: The interface of 'f' ('b') is not an abstract interface or a procedure with an explicit interface procedure(b) :: f procedure(c) :: g external :: h - !ERROR: The interface of 'i' (h) is not an abstract interface or a procedure with an explicit interface + !ERROR: The interface of 'i' ('h') is not an abstract interface or a procedure with an explicit interface procedure(h) :: i procedure(forward) :: j - !ERROR: The interface of 'k1' (bad1) is not an abstract interface or a procedure with an explicit interface + !ERROR: The interface of 'k1' ('bad1') is not an abstract interface or a procedure with an explicit interface procedure(bad1) :: k1 - !ERROR: The interface of 'k2' (bad2) is not an abstract interface or a procedure with an explicit interface + !ERROR: The interface of 'k2' ('bad2') is not an abstract interface or a procedure with an explicit interface procedure(bad2) :: k2 - !ERROR: The interface of 'k3' (bad3) is not an abstract interface or a procedure with an explicit interface + !ERROR: The interface of 'k3' ('bad3') is not an abstract interface or a procedure with an explicit interface procedure(bad3) :: k3 abstract interface diff --git a/flang/test/semantics/resolve32.f90 b/flang/test/semantics/resolve32.f90 index e94d32f..3d22dfc 100644 --- a/flang/test/semantics/resolve32.f90 +++ b/flang/test/semantics/resolve32.f90 @@ -57,7 +57,7 @@ module m procedure(foo), nopass, deferred :: f !ERROR: DEFERRED is required when an interface-name is provided procedure(foo), nopass :: g - !ERROR: The interface of 'h' (bar) is not an abstract interface or a procedure with an explicit interface + !ERROR: The interface of 'h' ('bar') is not an abstract interface or a procedure with an explicit interface procedure(bar), nopass, deferred :: h end type type t2 -- 2.7.4