From 2eb5ebd3665a38a4526b45cb3a31a132b2aa9927 Mon Sep 17 00:00:00 2001 From: Junchang Wang Date: Fri, 18 Jun 2010 10:02:33 +0800 Subject: [PATCH] PCI: check return value of pci_enable_device() when enabling bridges pci_enable_device can fail. In that case, a printed warning would be more appropriate. Signed-off-by: Justin P. Mattock Signed-off-by: Junchang Wang Signed-off-by: Jesse Barnes --- drivers/pci/bus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c index 42eea5fb..7f0af0e 100644 --- a/drivers/pci/bus.c +++ b/drivers/pci/bus.c @@ -240,6 +240,8 @@ void pci_enable_bridges(struct pci_bus *bus) if (dev->subordinate) { if (!pci_is_enabled(dev)) { retval = pci_enable_device(dev); + if (retval) + dev_err(&dev->dev, "Error enabling bridge (%d), continuing\n", retval); pci_set_master(dev); } pci_enable_bridges(dev->subordinate); -- 2.7.4