From 2ea514c5662f1c69642f21c9cc32c0fbfb8e9ffb Mon Sep 17 00:00:00 2001 From: Stella Stamenova Date: Tue, 9 Jul 2019 18:18:02 +0000 Subject: [PATCH] [lldb-suite] Skip TestMachCore on Windows This test was originally marked as expected failure on Windows, but it is timing out instead of outright failing now. The expectedFailure attribute does not correctly track timeouts (as in, they don't count as failures), so now this is causing the test suite to fail. llvm-svn: 365527 --- .../test/functionalities/postmortem/mach-core/TestMachCore.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py index a299a43..b03ea8d 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py @@ -26,7 +26,10 @@ class MachCoreTestCase(TestBase): lldb.DBG.SetSelectedPlatform(self._initial_platform) super(MachCoreTestCase, self).tearDown() - @expectedFailureAll(bugnumber="llvm.org/pr37371", hostoslist=["windows"]) + # This was originally marked as expected failure on Windows, but it has + # started timing out instead, so the expectedFailure attribute no longer + # correctly tracks it: llvm.org/pr37371 + @skipIfWindows def test_selected_thread(self): """Test that the right thread is selected after a core is loaded.""" # Create core form YAML. -- 2.7.4