From 2e9e05dfca18c7f09caa40396d6dd4f2b3ddc1d4 Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Fri, 30 Sep 2016 11:01:27 +0100 Subject: [PATCH] glx: return GL_FALSE from glx_screen_init where applicable. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Return GL_FALSE if we fail to find any fb/visual configs, otherwise we end up with all sorts of chaos further down the GLX stack. Signed-off-by: Emil Velikov Reviewed-by: Marek Olšák Reviewed-by: Ian Romanick --- src/glx/glxext.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index f6bc377..9ef7ff5 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -748,8 +748,11 @@ glx_screen_init(struct glx_screen *psc, psc->dpy = priv->dpy; psc->display = priv; - getVisualConfigs(psc, priv, screen); - getFBConfigs(psc, priv, screen); + if (!getVisualConfigs(psc, priv, screen)) + return GL_FALSE; + + if (!getFBConfigs(psc, priv, screen)) + return GL_FALSE; return GL_TRUE; } -- 2.7.4