From 2e78febdaee1265f1b911724b0a87fb5af2a3144 Mon Sep 17 00:00:00 2001 From: Pyry Haulos Date: Mon, 3 Apr 2017 08:32:07 -0700 Subject: [PATCH] Fix typo in framebuffer_srgb_unsupported_enum Test case was not assigning gl.getError() return value into a variable causing tests to always fail on implementations that don't support ES3.2 or GL_EXT_sRGB_write_control. Affects: dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_unsupported_enum Change-Id: Iafc38b8152f3371ce8c016c4f70feb2bb4604c69 --- modules/gles31/functional/es31fFboSRGBWriteControlTests.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/modules/gles31/functional/es31fFboSRGBWriteControlTests.cpp b/modules/gles31/functional/es31fFboSRGBWriteControlTests.cpp index 57f39d2..b4ebcac 100644 --- a/modules/gles31/functional/es31fFboSRGBWriteControlTests.cpp +++ b/modules/gles31/functional/es31fFboSRGBWriteControlTests.cpp @@ -1814,13 +1814,11 @@ bool FboSRGBUnsupportedEnumCase::isInvalidEnum (std::string functionName) log << tcu::TestLog::Message << "Checking call to " << functionName << tcu::TestLog::EndMessage; - std::ostringstream message; - gl.getError(); + error = gl.getError(); if (error != GL_INVALID_ENUM) { - message << functionName << " returned wrong value [" << glu::getErrorStr(error) << ", expected " << glu::getErrorStr(GL_INVALID_ENUM) << "]"; - log << tcu::TestLog::Message << message.str() << tcu::TestLog::EndMessage; + log << tcu::TestLog::Message << " returned wrong value [" << glu::getErrorStr(error) << ", expected " << glu::getErrorStr(GL_INVALID_ENUM) << "]" << tcu::TestLog::EndMessage; isOk = false; } -- 2.7.4