From 2e218fe8622139b4de57f032f3dfd7493d630092 Mon Sep 17 00:00:00 2001 From: "yurys@chromium.org" Date: Wed, 17 Jul 2013 12:16:16 +0000 Subject: [PATCH] Remove V8_DISABLE_DEPRECATIONS=1 from test-cpu-profiler.cc BUG=None R=loislo@chromium.org, yangguo@chromium.org Review URL: https://codereview.chromium.org/19554002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/cctest/test-cpu-profiler.cc | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc index 8168a61..eb72550 100644 --- a/test/cctest/test-cpu-profiler.cc +++ b/test/cctest/test-cpu-profiler.cc @@ -27,15 +27,12 @@ // // Tests of profiles generator and utilities. -#define V8_DISABLE_DEPRECATIONS 1 #include "v8.h" #include "cpu-profiler-inl.h" #include "cctest.h" #include "platform.h" #include "utils.h" #include "../include/v8-profiler.h" -#undef V8_DISABLE_DEPRECATIONS - using i::CodeEntry; using i::CpuProfile; using i::CpuProfiler; @@ -662,16 +659,15 @@ class TestApiCallbacks { : min_duration_ms_(min_duration_ms), is_warming_up_(false) {} - static v8::Handle Getter(v8::Local name, - const v8::AccessorInfo& info) { + static void Getter(v8::Local name, + const v8::PropertyCallbackInfo& info) { TestApiCallbacks* data = fromInfo(info); data->Wait(); - return v8::Int32::New(2013); } static void Setter(v8::Local name, v8::Local value, - const v8::AccessorInfo& info) { + const v8::PropertyCallbackInfo& info) { TestApiCallbacks* data = fromInfo(info); data->Wait(); } @@ -694,13 +690,8 @@ class TestApiCallbacks { } } - static TestApiCallbacks* fromInfo(const v8::AccessorInfo& info) { - void* data = v8::External::Cast(*info.Data())->Value(); - return reinterpret_cast(data); - } - - static TestApiCallbacks* fromInfo( - const v8::FunctionCallbackInfo& info) { + template + static TestApiCallbacks* fromInfo(const T& info) { void* data = v8::External::Cast(*info.Data())->Value(); return reinterpret_cast(data); } -- 2.7.4