From 2dea9ea9caa4a92a6e6d7dfa09b21a2a58e189ca Mon Sep 17 00:00:00 2001
From: Youness Alaoui <youness.alaoui@collabora.co.uk>
Date: Sat, 5 Apr 2014 03:41:48 -0400
Subject: [PATCH] Generate valid TCP connection check pairs

---
 agent/conncheck.c | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/agent/conncheck.c b/agent/conncheck.c
index fc817c2..f1fa916 100644
--- a/agent/conncheck.c
+++ b/agent/conncheck.c
@@ -1302,9 +1302,28 @@ static void priv_add_new_check_pair (NiceAgent *agent, guint stream_id, Componen
   }
 }
 
+static NiceCandidateTransport
+priv_match_transport (NiceCandidateTransport transport)
+{
+  switch (transport) {
+    case NICE_CANDIDATE_TRANSPORT_TCP_ACTIVE:
+      return NICE_CANDIDATE_TRANSPORT_TCP_PASSIVE;
+      break;
+    case NICE_CANDIDATE_TRANSPORT_TCP_PASSIVE:
+      return NICE_CANDIDATE_TRANSPORT_TCP_ACTIVE;
+      break;
+    case NICE_CANDIDATE_TRANSPORT_TCP_SO:
+    case NICE_CANDIDATE_TRANSPORT_UDP:
+    default:
+      return transport;
+      break;
+  }
+}
+
 static gboolean priv_conn_check_add_for_candidate_pair (NiceAgent *agent, guint stream_id, Component *component, NiceCandidate *local, NiceCandidate *remote)
 {
   gboolean ret = FALSE;
+
   /* note: do not create pairs where the local candidate is
    *       a srv-reflexive (ICE 5.7.3. "Pruning the pairs" ID-9) */
   if ((agent->compatibility == NICE_COMPATIBILITY_RFC5245 ||
@@ -1314,10 +1333,17 @@ static gboolean priv_conn_check_add_for_candidate_pair (NiceAgent *agent, guint
     return FALSE;
   }
 
+  /* note: do not create pairs where local candidate has TCP passive transport
+   *       (ice-tcp-13 6.2. "Forming the Check Lists") */
+  if (local->transport == NICE_CANDIDATE_TRANSPORT_TCP_PASSIVE) {
+    return FALSE;
+  }
   /* note: match pairs only if transport and address family are the same */
-  if (local->transport == remote->transport &&
+  if (local->transport == priv_match_transport (remote->transport) &&
      local->addr.s.addr.sa_family == remote->addr.s.addr.sa_family) {
 
+    nice_debug ("Agent %p, Adding check pair between %s and %s", agent,
+        local->foundation, remote->foundation);
     priv_add_new_check_pair (agent, stream_id, component, local, remote, NICE_CHECK_FROZEN, FALSE);
     ret = TRUE;
     if (component->state < NICE_COMPONENT_STATE_CONNECTED) {
-- 
2.7.4