From 2dc09f66b3b49d821e4bd68d3c97ff51d5e080d4 Mon Sep 17 00:00:00 2001 From: Sam Tebbs Date: Fri, 14 Sep 2018 15:16:17 +0000 Subject: [PATCH] [Aarch64] Added pattern to match zero extended bfxil gcc/ 2018-07-31 Sam Tebbs PR target/85628 * config/aarch64/aarch64.md (*aarch64_bfxilsi_uxtw): Define. gcc/testsuite 2018-07-31 Sam Tebbs PR target/85628 * gcc.target/aarch64/combine_bfxil.c (combine_zero_extended_int, foo6): New functions. From-SVN: r264315 --- gcc/ChangeLog | 5 +++++ gcc/config/aarch64/aarch64.md | 27 ++++++++++++++++++++++++ gcc/testsuite/ChangeLog | 6 ++++++ gcc/testsuite/gcc.target/aarch64/combine_bfxil.c | 21 +++++++++++++++++- 4 files changed, 58 insertions(+), 1 deletion(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 0b685b4..68612fe 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2018-09-14 Sam Tebbs + + PR target/85628 + * config/aarch64/aarch64.md (*aarch64_bfxilsi_uxtw): Define. + 2018-09-14 Jason Merrill Fix --enable-gather-detailed-mem-stats. diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index 88f6610..2c0dbab 100644 --- a/gcc/config/aarch64/aarch64.md +++ b/gcc/config/aarch64/aarch64.md @@ -5361,6 +5361,33 @@ [(set_attr "type" "bfm")] ) +; Zero-extended version of above (aarch64_bfxil) +(define_insn "*aarch64_bfxilsi_uxtw" + [(set (match_operand:DI 0 "register_operand" "=r,r") + (zero_extend:DI (ior:SI (and:SI (match_operand:SI 1 "register_operand" + "r,0") + (match_operand:SI 3 "const_int_operand" "n, Ulc")) + (and:SI (match_operand:SI 2 "register_operand" "0,r") + (match_operand:SI 4 "const_int_operand" "Ulc, n")))))] + "(INTVAL (operands[3]) == ~INTVAL (operands[4])) + && (aarch64_high_bits_all_ones_p (INTVAL (operands[3])) + || aarch64_high_bits_all_ones_p (INTVAL (operands[4])))" + { + switch (which_alternative) + { + case 0: + operands[3] = GEN_INT (ctz_hwi (~INTVAL (operands[3]))); + return "bfxil\\t%0, %1, 0, %3"; + case 1: + operands[3] = GEN_INT (ctz_hwi (~INTVAL (operands[4]))); + return "bfxil\\t%0, %2, 0, %3"; + default: + gcc_unreachable (); + } + } + [(set_attr "type" "bfm")] +) + ;; There are no canonicalisation rules for the position of the lshiftrt, ashift ;; operations within an IOR/AND RTX, therefore we have two patterns matching ;; each valid permutation. diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index f6ac25f..fcec319 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2018-09-14 Sam Tebbs + + PR target/85628 + * gcc.target/aarch64/combine_bfxil.c (combine_zero_extended_int, foo6): + New functions. + 2018-09-14 Kyrylo Tkachov PR tree-optimization/87259 diff --git a/gcc/testsuite/gcc.target/aarch64/combine_bfxil.c b/gcc/testsuite/gcc.target/aarch64/combine_bfxil.c index adb0582..98f6159 100644 --- a/gcc/testsuite/gcc.target/aarch64/combine_bfxil.c +++ b/gcc/testsuite/gcc.target/aarch64/combine_bfxil.c @@ -4,6 +4,13 @@ extern void abort (void); unsigned long long +combine_zero_extended_int (unsigned int a, unsigned int b) +{ + /* { dg-final { scan-assembler-not "uxtw\\t" } } */ + return (a & 0xffff0000ll) | (b & 0x0000ffffll); +} + +unsigned long long combine_balanced (unsigned long long a, unsigned long long b) { return (a & 0xffffffff00000000ll) | (b & 0x00000000ffffffffll); @@ -71,6 +78,13 @@ foo5 (unsigned int a, unsigned int b, unsigned int *c, unsigned int *d) *d = combine_unbalanced_int (b, a); } +void +foo6 (unsigned int a, unsigned int b, unsigned long long *c, unsigned long long *d) +{ + *c = combine_zero_extended_int(a, b); + *d = combine_zero_extended_int(b, a); +} + int main (void) { @@ -92,7 +106,12 @@ main (void) foo5 (a2, b2, &c2, &d2); if (c2 != 0x01234598) abort (); if (d2 != 0xfedcba67) abort (); + + unsigned long long c3, d3; + foo6 (a2, b2, &c3, &d3); + if (c3 != 0x0123ba98) abort (); + if (d3 != 0xfedc4567) abort (); return 0; } -/* { dg-final { scan-assembler-times "bfxil\\t" 10 } } */ +/* { dg-final { scan-assembler-times "bfxil\\t" 13 } } */ -- 2.7.4