From 2d889a87fb1c557f67adf9bc6dce90ddef7c7836 Mon Sep 17 00:00:00 2001 From: Jez Ng Date: Tue, 19 Jul 2022 21:22:27 -0400 Subject: [PATCH] [lld-macho] Read in new addrsig format The new format uses symbol relocations, as described in {D127637}. Reviewed By: #lld-macho, alx32 Differential Revision: https://reviews.llvm.org/D128938 --- lld/MachO/ICF.cpp | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/lld/MachO/ICF.cpp b/lld/MachO/ICF.cpp index 2a927b1..34ffd05 100644 --- a/lld/MachO/ICF.cpp +++ b/lld/MachO/ICF.cpp @@ -384,18 +384,13 @@ void macho::markAddrSigSymbols() { continue; assert(addrSigSection->subsections.size() == 1); - Subsection *subSection = &addrSigSection->subsections[0]; - ArrayRef &contents = subSection->isec->data; - - const uint8_t *pData = contents.begin(); - while (pData != contents.end()) { - unsigned size; - const char *err; - uint32_t symIndex = decodeULEB128(pData, &size, contents.end(), &err); - if (err) - fatal(toString(file) + ": could not decode addrsig section: " + err); - markSymAsAddrSig(obj->symbols[symIndex]); - pData += size; + const InputSection *isec = addrSigSection->subsections[0].isec; + + for (const Reloc &r : isec->relocs) { + if (auto *sym = r.referent.dyn_cast()) + markSymAsAddrSig(sym); + else + error(toString(isec) + ": unexpected section relocation"); } } } -- 2.7.4