From 2d225bbec1a0017ce315b17e0600eddaed306b0e Mon Sep 17 00:00:00 2001 From: Erik Pilkington Date: Mon, 23 Sep 2019 17:16:55 +0000 Subject: [PATCH] NFC: Fix a poorly-written test The author of r364954 foolishly forgot that == binds tighter than ?: llvm-svn: 372631 --- clang/test/SemaCXX/constexpr-builtin-bit-cast.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/clang/test/SemaCXX/constexpr-builtin-bit-cast.cpp b/clang/test/SemaCXX/constexpr-builtin-bit-cast.cpp index 8f4c347..0a12e7e 100644 --- a/clang/test/SemaCXX/constexpr-builtin-bit-cast.cpp +++ b/clang/test/SemaCXX/constexpr-builtin-bit-cast.cpp @@ -61,13 +61,13 @@ void test_record() { constexpr int_splicer splice{0x0C05FEFE, 0xCAFEBABE}; - static_assert(bit_cast(splice) == LITTLE_END - ? 0xCAFEBABE0C05FEFE - : 0x0C05FEFECAFEBABE); + static_assert(bit_cast(splice) == (LITTLE_END + ? 0xCAFEBABE0C05FEFE + : 0x0C05FEFECAFEBABE)); - static_assert(bit_cast(0xCAFEBABE0C05FEFE).x == LITTLE_END - ? 0x0C05FEFE - : 0xCAFEBABE); + static_assert(bit_cast(0xCAFEBABE0C05FEFE).x == (LITTLE_END + ? 0x0C05FEFE + : 0xCAFEBABE)); static_assert(round_trip(splice)); static_assert(round_trip(splice)); @@ -220,7 +220,7 @@ void backtrace() { void test_array_fill() { constexpr unsigned char a[4] = {1, 2}; constexpr unsigned int i = bit_cast(a); - static_assert(i == LITTLE_END ? 0x00000201 : 0x01020000, ""); // expected-warning {{converting the result of '?:' with integer constants to a boolean always evaluates to 'true'}} + static_assert(i == (LITTLE_END ? 0x00000201 : 0x01020000)); } typedef decltype(nullptr) nullptr_t; -- 2.7.4