From 2c722d18f32b1c1f82c7546b1e41edec47d88dce Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 20 May 2018 11:25:20 -0600 Subject: [PATCH] Remove buildsym_new_init buildsym_new_init is just an alias for buildsym_init. This removes it. In the long run buildsym_init will also go away; this patch just helps make things a bit clearer in the meantime. gdb/ChangeLog 2018-07-16 Tom Tromey * xcoffread.c (xcoff_new_init): Update. * mipsread.c (mipscoff_new_init): Update. * mdebugread.c (mdebug_build_psymtabs): Update. * elfread.c (elf_new_init): Update. * dbxread.c (dbx_new_init, coffstab_build_psymtabs) (elfstab_build_psymtabs, stabsect_build_psymtabs): Update. * buildsym.h (buildsym_new_init): Don't declare. * buildsym.c (buildsym_new_init): Remove. --- gdb/ChangeLog | 11 +++++++++++ gdb/buildsym.c | 12 +----------- gdb/buildsym.h | 4 +--- gdb/dbxread.c | 8 ++++---- gdb/elfread.c | 2 +- gdb/mdebugread.c | 2 +- gdb/mipsread.c | 2 +- gdb/xcoffread.c | 2 +- 8 files changed, 21 insertions(+), 22 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 74573a8..f803182 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,16 @@ 2018-07-16 Tom Tromey + * xcoffread.c (xcoff_new_init): Update. + * mipsread.c (mipscoff_new_init): Update. + * mdebugread.c (mdebug_build_psymtabs): Update. + * elfread.c (elf_new_init): Update. + * dbxread.c (dbx_new_init, coffstab_build_psymtabs) + (elfstab_build_psymtabs, stabsect_build_psymtabs): Update. + * buildsym.h (buildsym_new_init): Don't declare. + * buildsym.c (buildsym_new_init): Remove. + +2018-07-16 Tom Tromey + * stabsread.h (within_function): Move from buildsym.h. * stabsread.c (start_stabs): Clear within_function. * coffread.c (coff_start_symtab): Clear within_function. diff --git a/gdb/buildsym.c b/gdb/buildsym.c index fea4364..a87f58a 100644 --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -1751,7 +1751,7 @@ get_last_source_start_addr () corresponding to a psymtab. */ void -buildsym_init (void) +buildsym_init () { subfile_stack = NULL; @@ -1775,13 +1775,3 @@ buildsym_init (void) gdb_assert (pending_addrmap == NULL); gdb_assert (buildsym_compunit == NULL); } - -/* Initialize anything that needs initializing when a completely new - symbol file is specified (not just adding some symbols from another - file, e.g. a shared library). */ - -void -buildsym_new_init (void) -{ - buildsym_init (); -} diff --git a/gdb/buildsym.h b/gdb/buildsym.h index a6bed3c..77fc5bd 100644 --- a/gdb/buildsym.h +++ b/gdb/buildsym.h @@ -209,9 +209,7 @@ extern void augment_type_symtab (void); extern void scan_file_globals (struct objfile *objfile); -extern void buildsym_new_init (void); - -extern void buildsym_init (void); +extern void buildsym_init (); extern struct context_stack *push_context (int desc, CORE_ADDR valu); diff --git a/gdb/dbxread.c b/gdb/dbxread.c index ba0483e..7729315 100644 --- a/gdb/dbxread.c +++ b/gdb/dbxread.c @@ -568,7 +568,7 @@ static void dbx_new_init (struct objfile *ignore) { stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); init_header_files (); } @@ -3037,7 +3037,7 @@ coffstab_build_psymtabs (struct objfile *objfile, perror_with_name (name); stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); free_header_files (); init_header_files (); @@ -3125,7 +3125,7 @@ elfstab_build_psymtabs (struct objfile *objfile, asection *stabsect, perror_with_name (name); stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); free_header_files (); init_header_files (); @@ -3227,7 +3227,7 @@ stabsect_build_psymtabs (struct objfile *objfile, char *stab_name, perror_with_name (name); stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); free_header_files (); init_header_files (); diff --git a/gdb/elfread.c b/gdb/elfread.c index feca5ea..a5c4cdf 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -1325,7 +1325,7 @@ static void elf_new_init (struct objfile *ignore) { stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); } /* Perform any local cleanups required when we are done with a particular diff --git a/gdb/mdebugread.c b/gdb/mdebugread.c index 98f10b4..8b1db99 100644 --- a/gdb/mdebugread.c +++ b/gdb/mdebugread.c @@ -344,7 +344,7 @@ mdebug_build_psymtabs (minimal_symbol_reader &reader, debug_info = info; stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); free_header_files (); init_header_files (); diff --git a/gdb/mipsread.c b/gdb/mipsread.c index 7b6ec2e..3bdc507 100644 --- a/gdb/mipsread.c +++ b/gdb/mipsread.c @@ -54,7 +54,7 @@ static void mipscoff_new_init (struct objfile *ignore) { stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); } /* Initialize to read a symbol file (nothing to do). */ diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c index 6d4dfd9..31ba503 100644 --- a/gdb/xcoffread.c +++ b/gdb/xcoffread.c @@ -1920,7 +1920,7 @@ static void xcoff_new_init (struct objfile *objfile) { stabsread_new_init (); - buildsym_new_init (); + buildsym_init (); } /* Do initialization in preparation for reading symbols from OBJFILE. -- 2.7.4