From 2c5b900802b9a18d30c15cac76da110a529cdc2f Mon Sep 17 00:00:00 2001 From: Vitek Karas Date: Mon, 13 Jan 2020 05:31:55 -0800 Subject: [PATCH] Tiny cleanup - make host_startup_info return void The original return value was always 0 and never actually checked. --- src/installer/corehost/cli/host_startup_info.cpp | 3 +-- src/installer/corehost/cli/host_startup_info.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/installer/corehost/cli/host_startup_info.cpp b/src/installer/corehost/cli/host_startup_info.cpp index 155632b..a68f2f5 100644 --- a/src/installer/corehost/cli/host_startup_info.cpp +++ b/src/installer/corehost/cli/host_startup_info.cpp @@ -30,7 +30,7 @@ bool get_path_from_argv(pal::string_t *path) return false; } -int host_startup_info_t::parse( +void host_startup_info_t::parse( int argc, const pal::char_t* argv[]) { @@ -49,7 +49,6 @@ int host_startup_info_t::parse( trace::info(_X("Host path: [%s]"), host_path.c_str()); trace::info(_X("Dotnet path: [%s]"), dotnet_root.c_str()); trace::info(_X("App path: [%s]"), app_path.c_str()); - return 0; } bool host_startup_info_t::is_valid(host_mode_t mode) const diff --git a/src/installer/corehost/cli/host_startup_info.h b/src/installer/corehost/cli/host_startup_info.h index 2d85f69..4cb4b3e 100644 --- a/src/installer/corehost/cli/host_startup_info.h +++ b/src/installer/corehost/cli/host_startup_info.h @@ -16,7 +16,7 @@ struct host_startup_info_t const pal::char_t* dotnet_root_value, const pal::char_t* app_path_value); - int parse( + void parse( int argc, const pal::char_t* argv[]); -- 2.7.4