From 2bf8da684b712a16c67f3defc0dd97f175f8f4ad Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Wed, 26 Jan 2022 22:07:29 +0100 Subject: [PATCH] rs6000: Fix up #include or [PR104239] r12-4717-g7d37abedf58d66 added immintrin.h and x86gprintrin.h headers to rs6000, these headers are on x86 standalone headers that various programs include directly rather than including them through . Unfortunately, for that change the bmiintrin.h and bmi2intrin.h headers haven't been adjusted, so the effect is that if one includes them (without including also x86intrin.h first) #error will trigger. Furthermore, when including such headers conditionally as some real-world packages do, this means a regression. The following patch fixes it and matches what the x86 bmi{,2}intrin.h headers do. 2022-01-26 Jakub Jelinek PR target/104239 * config/rs6000/bmiintrin.h: Test _X86GPRINTRIN_H_INCLUDED instead of _X86INTRIN_H_INCLUDED and adjust #error wording. * config/rs6000/bmi2intrin.h: Likewise. * gcc.target/powerpc/pr104239-1.c: New test. * gcc.target/powerpc/pr104239-2.c: New test. --- gcc/config/rs6000/bmi2intrin.h | 4 ++-- gcc/config/rs6000/bmiintrin.h | 4 ++-- gcc/testsuite/gcc.target/powerpc/pr104239-1.c | 10 ++++++++++ gcc/testsuite/gcc.target/powerpc/pr104239-2.c | 10 ++++++++++ 4 files changed, 24 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/gcc.target/powerpc/pr104239-1.c create mode 100644 gcc/testsuite/gcc.target/powerpc/pr104239-2.c diff --git a/gcc/config/rs6000/bmi2intrin.h b/gcc/config/rs6000/bmi2intrin.h index 9bf36e9..931a61d 100644 --- a/gcc/config/rs6000/bmi2intrin.h +++ b/gcc/config/rs6000/bmi2intrin.h @@ -29,8 +29,8 @@ standard C or GNU C extensions, which are more portable and better optimized across multiple targets. */ -#if !defined _X86INTRIN_H_INCLUDED -# error "Never use directly; include instead." +#if !defined _X86GPRINTRIN_H_INCLUDED +# error "Never use directly; include instead." #endif #ifndef _BMI2INTRIN_H_INCLUDED diff --git a/gcc/config/rs6000/bmiintrin.h b/gcc/config/rs6000/bmiintrin.h index 8845f70..76cbc47 100644 --- a/gcc/config/rs6000/bmiintrin.h +++ b/gcc/config/rs6000/bmiintrin.h @@ -29,8 +29,8 @@ standard C or GNU C extensions, which are more portable and better optimized across multiple targets. */ -#if !defined _X86INTRIN_H_INCLUDED -# error "Never use directly; include instead." +#if !defined _X86GPRINTRIN_H_INCLUDED +# error "Never use directly; include instead." #endif #ifndef _BMIINTRIN_H_INCLUDED diff --git a/gcc/testsuite/gcc.target/powerpc/pr104239-1.c b/gcc/testsuite/gcc.target/powerpc/pr104239-1.c new file mode 100644 index 0000000..eacdedd --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr104239-1.c @@ -0,0 +1,10 @@ +/* PR target/104239 */ +/* { dg-do compile } */ +/* { dg-options "-O2 -mdejagnu-cpu=power8 -DNO_WARN_X86_INTRINSICS" } */ +/* { dg-require-effective-target powerpc_p8vector_ok } */ + +#if __has_include() +#include +#endif + +int i; diff --git a/gcc/testsuite/gcc.target/powerpc/pr104239-2.c b/gcc/testsuite/gcc.target/powerpc/pr104239-2.c new file mode 100644 index 0000000..1bf316f --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr104239-2.c @@ -0,0 +1,10 @@ +/* PR target/104239 */ +/* { dg-do compile } */ +/* { dg-options "-O2 -mdejagnu-cpu=power8 -DNO_WARN_X86_INTRINSICS" } */ +/* { dg-require-effective-target powerpc_p8vector_ok } */ + +#if __has_include() +#include +#endif + +int i; -- 2.7.4