From 2be92348f8ba6eabcdc743d0aa8b2f4431d43fd1 Mon Sep 17 00:00:00 2001 From: SangYoun Kwak Date: Fri, 13 Oct 2023 20:15:22 +0900 Subject: [PATCH] upgrade-scripts: Fix to invoke as an error when untar fails Previously, if the untaring of any delta file from the delta.tar.gz fails, then the script ignored it and continued to the next delta file. This may cause some delta files to be not applied which causes the failure of the FOTA as a result. To prevent this, the log message was changed to 'Error' from 'Info" and 'exit_error' was used instead of 'continue'. Change-Id: Idffe1387a58b9a358f717bae4a334405b8946da4 Signed-off-by: SangYoun Kwak --- scripts/upgrade-support/upgrade-common.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/upgrade-support/upgrade-common.inc b/scripts/upgrade-support/upgrade-common.inc index 2829dc3..e11a0cf 100644 --- a/scripts/upgrade-support/upgrade-common.inc +++ b/scripts/upgrade-support/upgrade-common.inc @@ -206,8 +206,8 @@ upgrade_images() { fi if ! /bin/tar tf "$DELTA_TAR" "$DELTA_NAME"; then - flog "[Info] There is no delta $DELTA_NAME for label $LABEL_NAME from part $PART_NAME" - continue + flog "[Error] There is no delta $DELTA_NAME for label $LABEL_NAME from part $PART_NAME" + exit_error fi local NEXT_PARTITION="$(/usr/bin/blkid-print "$EMMC_DEVICE" "$PART_NAME" "$NEXT_AB" |\ -- 2.7.4