From 2be18749277ac142e1c4d7296d915c50002ab60e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Tue, 21 Jul 2015 11:10:04 +0100 Subject: [PATCH] rmdemux: fix taglist leak merge doesn't take ownership, so must unref the old tags if we do merge. --- gst/realmedia/rmdemux.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gst/realmedia/rmdemux.c b/gst/realmedia/rmdemux.c index f170b21..fccd823 100644 --- a/gst/realmedia/rmdemux.c +++ b/gst/realmedia/rmdemux.c @@ -1930,11 +1930,15 @@ gst_rmdemux_parse_cont (GstRMDemux * rmdemux, const guint8 * data, int length) tags = gst_rm_utils_read_tags (data, length, gst_rm_utils_read_string16); if (tags) { + GstTagList *old_tags = rmdemux->pending_tags; + GST_LOG_OBJECT (rmdemux, "tags: %" GST_PTR_FORMAT, tags); rmdemux->pending_tags = - gst_tag_list_merge (rmdemux->pending_tags, tags, GST_TAG_MERGE_APPEND); + gst_tag_list_merge (old_tags, tags, GST_TAG_MERGE_APPEND); + gst_tag_list_unref (tags); + gst_tag_list_unref (old_tags); } } -- 2.7.4