From 2bc20e5e2273f5768fed25327a7d5d9aa33f81f9 Mon Sep 17 00:00:00 2001
From: =?utf8?q?=EC=9D=B4=ED=95=9C=EC=A2=85/=EB=8F=99=EC=9E=91=EC=A0=9C?=
 =?utf8?q?=EC=96=B4Lab=28SR=29/Engineer/=EC=82=BC=EC=84=B1=EC=A0=84?=
 =?utf8?q?=EC=9E=90?= <hanjoung.lee@samsung.com>
Date: Tue, 28 Aug 2018 09:54:33 +0900
Subject: [PATCH] [neurun] NodeVisitor argument as rvalue ref (#2483)

Edit `graph::operation::Node::accept` method to accept rvalue
reference instead of lvalue reference.

Find the usage from #2479.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
---
 runtimes/neurun/src/graph/operation/AvgPool2D.cc      | 2 +-
 runtimes/neurun/src/graph/operation/AvgPool2D.h       | 2 +-
 runtimes/neurun/src/graph/operation/Concat.cc         | 2 +-
 runtimes/neurun/src/graph/operation/Concat.h          | 2 +-
 runtimes/neurun/src/graph/operation/Conv2D.cc         | 2 +-
 runtimes/neurun/src/graph/operation/Conv2D.h          | 2 +-
 runtimes/neurun/src/graph/operation/FullyConnected.cc | 2 +-
 runtimes/neurun/src/graph/operation/FullyConnected.h  | 2 +-
 runtimes/neurun/src/graph/operation/MaxPool2D.cc      | 2 +-
 runtimes/neurun/src/graph/operation/MaxPool2D.h       | 2 +-
 runtimes/neurun/src/graph/operation/NOP.cc            | 2 +-
 runtimes/neurun/src/graph/operation/NOP.h             | 2 +-
 runtimes/neurun/src/graph/operation/Node.h            | 2 +-
 runtimes/neurun/src/graph/operation/Reshape.cc        | 2 +-
 runtimes/neurun/src/graph/operation/Reshape.h         | 2 +-
 runtimes/neurun/src/graph/operation/Softmax.cc        | 2 +-
 runtimes/neurun/src/graph/operation/Softmax.h         | 2 +-
 runtimes/neurun/test/graph/operation/Set.cc           | 2 +-
 runtimes/neurun/test/graph/verifier/Verifier.cc       | 2 +-
 19 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/runtimes/neurun/src/graph/operation/AvgPool2D.cc b/runtimes/neurun/src/graph/operation/AvgPool2D.cc
index 2aa48b2..a2997ec 100644
--- a/runtimes/neurun/src/graph/operation/AvgPool2D.cc
+++ b/runtimes/neurun/src/graph/operation/AvgPool2D.cc
@@ -15,7 +15,7 @@ namespace AvgPool2D
 namespace Implicit
 {
 
-void Node::accept(NodeVisitor &v) const { v.visit(*this); }
+void Node::accept(NodeVisitor &&v) const { v.visit(*this); }
 
 void Node::inputs(const operand::IndexSet &indexes)
 {
diff --git a/runtimes/neurun/src/graph/operation/AvgPool2D.h b/runtimes/neurun/src/graph/operation/AvgPool2D.h
index 8b4da0b..b639e8c 100644
--- a/runtimes/neurun/src/graph/operation/AvgPool2D.h
+++ b/runtimes/neurun/src/graph/operation/AvgPool2D.h
@@ -25,7 +25,7 @@ public:
   }
 
 public:
-  virtual void accept(NodeVisitor &) const override;
+  virtual void accept(NodeVisitor &&) const override;
 
 public:
   virtual operand::IndexSet inputs() const override { return {_op->param().ifm_index}; }
diff --git a/runtimes/neurun/src/graph/operation/Concat.cc b/runtimes/neurun/src/graph/operation/Concat.cc
index 61e6835..3732247 100644
--- a/runtimes/neurun/src/graph/operation/Concat.cc
+++ b/runtimes/neurun/src/graph/operation/Concat.cc
@@ -13,7 +13,7 @@ namespace operation
 namespace Concat
 {
 
-void Node::accept(NodeVisitor &v) const { v.visit(*this); }
+void Node::accept(NodeVisitor &&v) const { v.visit(*this); }
 
 operand::IndexSet Node::inputs() const
 {
diff --git a/runtimes/neurun/src/graph/operation/Concat.h b/runtimes/neurun/src/graph/operation/Concat.h
index 5166988..c417aca 100644
--- a/runtimes/neurun/src/graph/operation/Concat.h
+++ b/runtimes/neurun/src/graph/operation/Concat.h
@@ -21,7 +21,7 @@ public:
   Node(std::unique_ptr<::internal::tflite::op::Concat::Node> &&op) : _op{std::move(op)} {}
 
 public:
-  virtual void accept(NodeVisitor &) const override;
+  virtual void accept(NodeVisitor &&) const override;
 
 public:
   virtual operand::IndexSet inputs() const override;
diff --git a/runtimes/neurun/src/graph/operation/Conv2D.cc b/runtimes/neurun/src/graph/operation/Conv2D.cc
index cf7381e..d88c0d2 100644
--- a/runtimes/neurun/src/graph/operation/Conv2D.cc
+++ b/runtimes/neurun/src/graph/operation/Conv2D.cc
@@ -15,7 +15,7 @@ namespace Conv2D
 namespace Implicit
 {
 
-void Node::accept(NodeVisitor &v) const { v.visit(*this); }
+void Node::accept(NodeVisitor &&v) const { v.visit(*this); }
 
 void Node::inputs(const operand::IndexSet &indexes)
 {
diff --git a/runtimes/neurun/src/graph/operation/Conv2D.h b/runtimes/neurun/src/graph/operation/Conv2D.h
index 8021f86..09c9b2d 100644
--- a/runtimes/neurun/src/graph/operation/Conv2D.h
+++ b/runtimes/neurun/src/graph/operation/Conv2D.h
@@ -23,7 +23,7 @@ public:
   Node(std::unique_ptr<::internal::tflite::op::Conv2D::implicit::Node> &&op) : _op{std::move(op)} {}
 
 public:
-  virtual void accept(NodeVisitor &) const override;
+  virtual void accept(NodeVisitor &&) const override;
 
 public:
   virtual operand::IndexSet inputs() const override
diff --git a/runtimes/neurun/src/graph/operation/FullyConnected.cc b/runtimes/neurun/src/graph/operation/FullyConnected.cc
index cdb9de3..d39f01b 100644
--- a/runtimes/neurun/src/graph/operation/FullyConnected.cc
+++ b/runtimes/neurun/src/graph/operation/FullyConnected.cc
@@ -13,7 +13,7 @@ namespace operation
 namespace FullyConnected
 {
 
-void Node::accept(NodeVisitor &v) const { v.visit(*this); }
+void Node::accept(NodeVisitor &&v) const { v.visit(*this); }
 
 void Node::inputs(const operand::IndexSet &indexes)
 {
diff --git a/runtimes/neurun/src/graph/operation/FullyConnected.h b/runtimes/neurun/src/graph/operation/FullyConnected.h
index 396dfe0..6e7adeb 100644
--- a/runtimes/neurun/src/graph/operation/FullyConnected.h
+++ b/runtimes/neurun/src/graph/operation/FullyConnected.h
@@ -21,7 +21,7 @@ public:
   Node(std::unique_ptr<::internal::tflite::op::FullyConnected::Node> &&op) : _op{std::move(op)} {}
 
 public:
-  virtual void accept(NodeVisitor &) const override;
+  virtual void accept(NodeVisitor &&) const override;
 
 public:
   virtual operand::IndexSet inputs() const override
diff --git a/runtimes/neurun/src/graph/operation/MaxPool2D.cc b/runtimes/neurun/src/graph/operation/MaxPool2D.cc
index eb79310..c56571f 100644
--- a/runtimes/neurun/src/graph/operation/MaxPool2D.cc
+++ b/runtimes/neurun/src/graph/operation/MaxPool2D.cc
@@ -15,7 +15,7 @@ namespace MaxPool2D
 namespace Implicit
 {
 
-void Node::accept(NodeVisitor &v) const { v.visit(*this); }
+void Node::accept(NodeVisitor &&v) const { v.visit(*this); }
 
 void Node::inputs(const operand::IndexSet &indexes)
 {
diff --git a/runtimes/neurun/src/graph/operation/MaxPool2D.h b/runtimes/neurun/src/graph/operation/MaxPool2D.h
index 65f829f..8b0ab22 100644
--- a/runtimes/neurun/src/graph/operation/MaxPool2D.h
+++ b/runtimes/neurun/src/graph/operation/MaxPool2D.h
@@ -25,7 +25,7 @@ public:
   }
 
 public:
-  virtual void accept(NodeVisitor &) const override;
+  virtual void accept(NodeVisitor &&) const override;
 
 public:
   virtual operand::IndexSet inputs() const override { return {_op->param().ifm_index}; }
diff --git a/runtimes/neurun/src/graph/operation/NOP.cc b/runtimes/neurun/src/graph/operation/NOP.cc
index 07fcf29..cb96bda 100644
--- a/runtimes/neurun/src/graph/operation/NOP.cc
+++ b/runtimes/neurun/src/graph/operation/NOP.cc
@@ -11,7 +11,7 @@ namespace operation
 namespace NOP
 {
 
-void Node::accept(NodeVisitor &v) const { v.visit(*this); }
+void Node::accept(NodeVisitor &&v) const { v.visit(*this); }
 
 operand::IndexSet Node::inputs() const
 {
diff --git a/runtimes/neurun/src/graph/operation/NOP.h b/runtimes/neurun/src/graph/operation/NOP.h
index 25490fe..6f909bc 100644
--- a/runtimes/neurun/src/graph/operation/NOP.h
+++ b/runtimes/neurun/src/graph/operation/NOP.h
@@ -21,7 +21,7 @@ public:
   Node(std::unique_ptr<::internal::tflite::op::NOP::Node> &&op) : _op{std::move(op)} {}
 
 public:
-  virtual void accept(NodeVisitor &) const override;
+  virtual void accept(NodeVisitor &&) const override;
 
 public:
   virtual operand::IndexSet inputs() const override;
diff --git a/runtimes/neurun/src/graph/operation/Node.h b/runtimes/neurun/src/graph/operation/Node.h
index 27d7abb..cd33bc8 100644
--- a/runtimes/neurun/src/graph/operation/Node.h
+++ b/runtimes/neurun/src/graph/operation/Node.h
@@ -23,7 +23,7 @@ public:
   virtual ~Node() = default;
 
 public:
-  virtual void accept(NodeVisitor &) const = 0;
+  virtual void accept(NodeVisitor &&) const = 0;
 
 public:
   virtual operand::IndexSet inputs() const = 0;
diff --git a/runtimes/neurun/src/graph/operation/Reshape.cc b/runtimes/neurun/src/graph/operation/Reshape.cc
index a72d81c..6c60eff 100644
--- a/runtimes/neurun/src/graph/operation/Reshape.cc
+++ b/runtimes/neurun/src/graph/operation/Reshape.cc
@@ -13,7 +13,7 @@ namespace operation
 namespace Reshape
 {
 
-void Node::accept(NodeVisitor &v) const { v.visit(*this); }
+void Node::accept(NodeVisitor &&v) const { v.visit(*this); }
 
 void Node::inputs(const operand::IndexSet &indexes)
 {
diff --git a/runtimes/neurun/src/graph/operation/Reshape.h b/runtimes/neurun/src/graph/operation/Reshape.h
index 11b712e..56d2898 100644
--- a/runtimes/neurun/src/graph/operation/Reshape.h
+++ b/runtimes/neurun/src/graph/operation/Reshape.h
@@ -21,7 +21,7 @@ public:
   Node(std::unique_ptr<::internal::tflite::op::Reshape::Node> &&op) : _op{std::move(op)} {}
 
 public:
-  virtual void accept(NodeVisitor &) const override;
+  virtual void accept(NodeVisitor &&) const override;
 
 public:
   virtual operand::IndexSet inputs() const override
diff --git a/runtimes/neurun/src/graph/operation/Softmax.cc b/runtimes/neurun/src/graph/operation/Softmax.cc
index f3ca861..026fb6e 100644
--- a/runtimes/neurun/src/graph/operation/Softmax.cc
+++ b/runtimes/neurun/src/graph/operation/Softmax.cc
@@ -13,7 +13,7 @@ namespace operation
 namespace Softmax
 {
 
-void Node::accept(NodeVisitor &v) const { v.visit(*this); }
+void Node::accept(NodeVisitor &&v) const { v.visit(*this); }
 
 void Node::inputs(const operand::IndexSet &indexes)
 {
diff --git a/runtimes/neurun/src/graph/operation/Softmax.h b/runtimes/neurun/src/graph/operation/Softmax.h
index 06583b1..2d2f74f 100644
--- a/runtimes/neurun/src/graph/operation/Softmax.h
+++ b/runtimes/neurun/src/graph/operation/Softmax.h
@@ -21,7 +21,7 @@ public:
   Node(std::unique_ptr<::internal::tflite::op::Softmax::Node> &&op) : _op{std::move(op)} {}
 
 public:
-  virtual void accept(NodeVisitor &) const override;
+  virtual void accept(NodeVisitor &&) const override;
 
 public:
   virtual operand::IndexSet inputs() const override { return {_op->param().input_index}; }
diff --git a/runtimes/neurun/test/graph/operation/Set.cc b/runtimes/neurun/test/graph/operation/Set.cc
index e63a52c..f533c6a 100644
--- a/runtimes/neurun/test/graph/operation/Set.cc
+++ b/runtimes/neurun/test/graph/operation/Set.cc
@@ -12,7 +12,7 @@ public:
   TestNode() = default;
 
 public:
-  virtual void accept(neurun::graph::operation::NodeVisitor &) const override {}
+  virtual void accept(neurun::graph::operation::NodeVisitor &&) const override {}
 
 public:
   virtual neurun::graph::operand::IndexSet inputs() const { return {1, 2, 3, 4}; }
diff --git a/runtimes/neurun/test/graph/verifier/Verifier.cc b/runtimes/neurun/test/graph/verifier/Verifier.cc
index a609063..bf27339 100644
--- a/runtimes/neurun/test/graph/verifier/Verifier.cc
+++ b/runtimes/neurun/test/graph/verifier/Verifier.cc
@@ -15,7 +15,7 @@ public:
   }
 
 public:
-  virtual void accept(neurun::graph::operation::NodeVisitor &) const override {}
+  virtual void accept(neurun::graph::operation::NodeVisitor &&) const override {}
 
 public:
   virtual neurun::graph::operand::IndexSet inputs() const override { return {_input}; }
-- 
2.7.4