From 2bbe97830ae623a519291eece719ee74108571ff Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Tue, 14 Mar 2017 10:51:50 +0300 Subject: [PATCH] staging/atomisp: silence uninitialized variable warnings These print an uninitialized value for "opt". Let's just remove the printk. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- .../staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c index 327a5c5..7f7c6d5 100644 --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c @@ -128,11 +128,9 @@ static ssize_t iunit_dbgfun_store(struct device_driver *drv, const char *buf, unsigned int opt; int ret; - if (kstrtouint(buf, 10, &opt)) { - dev_err(atomisp_dev, "%s setting %d value invalid\n", - __func__, opt); - return -EINVAL; - } + ret = kstrtouint(buf, 10, &opt); + if (ret) + return ret; ret = atomisp_set_css_dbgfunc(iunit_debug.isp, opt); if (ret) @@ -154,11 +152,9 @@ static ssize_t iunit_dbgopt_store(struct device_driver *drv, const char *buf, unsigned int opt; int ret; - if (kstrtouint(buf, 10, &opt)) { - dev_err(atomisp_dev, "%s setting %d value invalid\n", - __func__, opt); - return -EINVAL; - } + ret = kstrtouint(buf, 10, &opt); + if (ret) + return ret; iunit_debug.dbgopt = opt; ret = iunit_dump_dbgopt(iunit_debug.isp, iunit_debug.dbgopt); -- 2.7.4