From 2b8a09e1ed5c78cf5ae75fdcf55e1b5349a2d47c Mon Sep 17 00:00:00 2001 From: Yuanfang Chen Date: Fri, 26 Jun 2020 14:55:00 -0700 Subject: [PATCH] [MemorySSA] Update comment in PassBuilder Is teaching the LoopFullUnrollPass to preserve MemorySSA very hard or just impossible? Reviewed By: asbirlea Differential Revision: https://reviews.llvm.org/D82618 --- llvm/lib/Passes/PassBuilder.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/llvm/lib/Passes/PassBuilder.cpp b/llvm/lib/Passes/PassBuilder.cpp index d1900ab..7bdeb4d 100644 --- a/llvm/lib/Passes/PassBuilder.cpp +++ b/llvm/lib/Passes/PassBuilder.cpp @@ -508,8 +508,7 @@ FunctionPassManager PassBuilder::buildO1FunctionSimplificationPipeline( std::move(LPM1), EnableMSSALoopDependency, DebugLogging)); FPM.addPass(SimplifyCFGPass()); FPM.addPass(InstCombinePass()); - // The loop passes in LPM2 (IndVarSimplifyPass, LoopIdiomRecognizePass, - // LoopDeletionPass and LoopFullUnrollPass) do not preserve MemorySSA. + // The loop passes in LPM2 (LoopFullUnrollPass) do not preserve MemorySSA. // *All* loop passes must preserve it, in order to be able to use it. FPM.addPass(createFunctionToLoopPassAdaptor( std::move(LPM2), /*UseMemorySSA=*/false, DebugLogging)); -- 2.7.4