From 2b4f1592057c8868f330d31041a5ab94a5087721 Mon Sep 17 00:00:00 2001 From: Bruce Forstall Date: Sat, 29 Jun 2019 14:57:58 -0700 Subject: [PATCH] Remove an old CoreFX exclusion file (#25500) Plus, add comments to the new exclusion file --- tests/CoreFX/CoreFX.issues.rsp | 22 ++++++++++++++ tests/scripts/run-corefx-tests-exclusions.txt | 41 --------------------------- tests/scripts/run-corefx-tests.bat | 2 +- 3 files changed, 23 insertions(+), 42 deletions(-) delete mode 100644 tests/scripts/run-corefx-tests-exclusions.txt diff --git a/tests/CoreFX/CoreFX.issues.rsp b/tests/CoreFX/CoreFX.issues.rsp index a311de2..7b458aa 100644 --- a/tests/CoreFX/CoreFX.issues.rsp +++ b/tests/CoreFX/CoreFX.issues.rsp @@ -1,3 +1,25 @@ +# This is a "response file" used to pass fine-grained test exclusions to the +# corefx xunit test wrapper scripts, RunTests.cmd or RunTests.sh. Lines here +# should be in a format that xunit understands. Lines beginning with '#' are +# comment lines and are ignored. +# +# The interesting xunit exclusion syntax is (extracted from help screen for +# "dotnet.exe xunit.console.dll -?"): +# +# ------------------------------------------------------------------------- +# -nomethod "name" : do not run a given test method (can be fully specified or use a wildcard; +# : i.e., 'MyNamespace.MyClass.MyTestMethod' or '*.MyTestMethod') +# : if specified more than once, acts as an AND operation +# -noclass "name" : do not run any methods in a given test class (should be fully +# : specified; i.e., 'MyNamespace.MyClass') +# : if specified more than once, acts as an AND operation +# -nonamespace "name" : do not run any methods in a given namespace (i.e., +# : 'MyNamespace.MySubNamespace') +# : if specified more than once, acts as an AND operation +# ------------------------------------------------------------------------- +# +# Please list a GitHub issue for every exclusion. + -notrait category=OuterLoop -notrait category=RequiresElevation diff --git a/tests/scripts/run-corefx-tests-exclusions.txt b/tests/scripts/run-corefx-tests-exclusions.txt deleted file mode 100644 index 0c852dc..0000000 --- a/tests/scripts/run-corefx-tests-exclusions.txt +++ /dev/null @@ -1,41 +0,0 @@ -# This is a "response file" used to pass fine-grained test exclusions to the -# corefx xunit test wrapper scripts, RunTests.cmd or RunTests.sh. Lines here -# should be in a format that xunit understands. Lines beginning with '#' are -# comment lines and are ignored. -# -# The interesting xunit exclusion syntax is (extracted from help screen for -# "dotnet.exe xunit.console.dll -?"): -# -# ------------------------------------------------------------------------- -# -nomethod "name" : do not run a given test method (can be fully specified or use a wildcard; -# : i.e., 'MyNamespace.MyClass.MyTestMethod' or '*.MyTestMethod') -# : if specified more than once, acts as an AND operation -# -noclass "name" : do not run any methods in a given test class (should be fully -# : specified; i.e., 'MyNamespace.MyClass') -# : if specified more than once, acts as an AND operation -# -nonamespace "name" : do not run any methods in a given namespace (i.e., -# : 'MyNamespace.MySubNamespace') -# : if specified more than once, acts as an AND operation -# ------------------------------------------------------------------------- -# -# Please list a GitHub issue for every exclusion. - -# https://github.com/dotnet/coreclr/issues/22442 --nomethod "Microsoft.Win32.SystemEventsTests.CreateTimerTests.ConcurrentTimers" --nomethod "Microsoft.Win32.SystemEventsTests.SessionSwitchTests.SignalsSessionSwitch" - -# https://github.com/dotnet/coreclr/issues/24185 --nomethod "System.Threading.Tasks.Tests.TaskRtTests_Core.RunTaskWaitTest_NegativeTests" - -# Too many "random" timeout failures --nonamespace "System.Net.Http.Functional.Tests" --noclass "System.Net.Tests.HttpListenerTimeoutManagerWindowsTests" - -# Minopts timeout. https://github.com/dotnet/coreclr/issues/18912 --nomethod "System.Text.RegularExpressions.Tests.RegexMatchTests.Match_ExcessPrefix" - -# arm32/arm64 timeout. https://github.com/dotnet/coreclr/issues/22414 --nomethod "System.Numerics.Tests.ToStringTest.RunRegionSpecificStandardFormatToStringTests" - -# https://github.com/dotnet/coreclr/issues/24265 --nomethod "System.IO.Tests.CtorTests.NullEncodingThrows" diff --git a/tests/scripts/run-corefx-tests.bat b/tests/scripts/run-corefx-tests.bat index 18758fd..2ff3a33 100644 --- a/tests/scripts/run-corefx-tests.bat +++ b/tests/scripts/run-corefx-tests.bat @@ -19,7 +19,7 @@ echo ^ -- Path to test exclusion file, e.g., C:\coreclr\te echo ^ -- Architecture to run, either ARM or ARM64. (We can't depend on PROCESSOR_ARCHITECTURE because echo the batch script might be invoked with an ARM64 CMD but we need to run ARM.) echo ^ -- Path to test exclusion response file, passed to RunTests.cmd and then xunit, e.g., -echo C:\coreclr\tests\scripts\run-corefx-tests-exclusions.txt +echo C:\coreclr\tests\CoreFX\CoreFX.issues.rsp echo. echo The ^ is a file with a list of assemblies for which the echo tests should not be run. This allows excluding failing tests by excluding the -- 2.7.4