From 2ae182258c49724e4daaae196de829ea65c116e8 Mon Sep 17 00:00:00 2001 From: =?utf8?q?D=C3=A1vid=20Bolvansk=C3=BD?= Date: Sun, 20 Sep 2020 17:42:39 +0200 Subject: [PATCH] [Diagnostics] Fixed -Wsizeof-array-div false positive when divisor is sizeof reference type (PR47495) --- clang/lib/Sema/SemaExpr.cpp | 2 +- clang/test/Sema/div-sizeof-array.cpp | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index 501e1ae..736a6c1 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++ b/clang/lib/Sema/SemaExpr.cpp @@ -10038,7 +10038,7 @@ static void DiagnoseDivisionSizeofPointerOrArray(Sema &S, Expr *LHS, Expr *RHS, QualType ArrayElemTy = ArrayTy->getElementType(); if (ArrayElemTy != S.Context.getBaseElementType(ArrayTy) || ArrayElemTy->isDependentType() || RHSTy->isDependentType() || - ArrayElemTy->isCharType() || + RHSTy->isReferenceType() || ArrayElemTy->isCharType() || S.Context.getTypeSize(ArrayElemTy) == S.Context.getTypeSize(RHSTy)) return; S.Diag(Loc, diag::warn_division_sizeof_array) diff --git a/clang/test/Sema/div-sizeof-array.cpp b/clang/test/Sema/div-sizeof-array.cpp index e295a9dec..898ff42 100644 --- a/clang/test/Sema/div-sizeof-array.cpp +++ b/clang/test/Sema/div-sizeof-array.cpp @@ -42,4 +42,8 @@ void test(void) { float m[4][4]; int d1 = sizeof(m) / sizeof(**m); + + int array[10]; + int narray = sizeof(array) / sizeof(int &); + int narray2 = sizeof(array) / sizeof(decltype(array[0])); } -- 2.7.4