From 29f8404ce72d2786d7167614b07a6fe11dd91298 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 31 Aug 2000 18:36:18 +0000 Subject: [PATCH] 2000-08-31 Kazu Hirata * frags.c: Fix formatting. * macro.c: Likewise. --- gas/ChangeLog | 5 ++ gas/frags.c | 133 +++++++++++++++++++++----------------------------- gas/macro.c | 127 ++++++++++++++++++++++++----------------------- 3 files changed, 126 insertions(+), 139 deletions(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index bc19206ed6e..0174bdae316 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2000-08-31 Kazu Hirata + + * frags.c: Fix formatting. + * macro.c: Likewise. + 2000-08-31 Eric Christopher * config/tc-mn10300.c: Cleanup and fix warnings. diff --git a/gas/frags.c b/gas/frags.c index 5c31b7e8931..f5a9d9e5e59 100644 --- a/gas/frags.c +++ b/gas/frags.c @@ -27,6 +27,7 @@ extern fragS zero_address_frag; extern fragS bss_address_frag; /* Initialization for frag routines. */ + void frag_init () { @@ -37,6 +38,7 @@ frag_init () /* Allocate a frag on the specified obstack. Call this routine from everywhere else, so that all the weird alignment hackery can be done in just one place. */ + fragS * frag_alloc (ob) struct obstack *ob; @@ -53,15 +55,12 @@ frag_alloc (ob) return ptr; } -/* - * frag_grow() - * - * Try to augment current frag by nchars chars. - * If there is no room, close of the current frag with a ".fill 0" - * and begin a new frag. Unless the new frag has nchars chars available - * do not return. Do not set up any fields of *now_frag. - */ -void +/* Try to augment current frag by nchars chars. + If there is no room, close of the current frag with a ".fill 0" + and begin a new frag. Unless the new frag has nchars chars available + do not return. Do not set up any fields of *now_frag. */ + +void frag_grow (nchars) unsigned int nchars; { @@ -87,30 +86,27 @@ frag_grow (nchars) as_fatal (_("Can't extend frag %d. chars"), nchars); } -/* - * frag_new() - * - * Call this to close off a completed frag, and start up a new (empty) - * frag, in the same subsegment as the old frag. - * [frchain_now remains the same but frag_now is updated.] - * Because this calculates the correct value of fr_fix by - * looking at the obstack 'frags', it needs to know how many - * characters at the end of the old frag belong to the maximal - * variable part; The rest must belong to fr_fix. - * It doesn't actually set up the old frag's fr_var. You may have - * set fr_var == 1, but allocated 10 chars to the end of the frag; - * In this case you pass old_frags_var_max_size == 10. - * In fact, you may use fr_var for something totally unrelated to the - * size of the variable part of the frag; None of the generic frag - * handling code makes use of fr_var. - * - * Make a new frag, initialising some components. Link new frag at end - * of frchain_now. - */ -void +/* Call this to close off a completed frag, and start up a new (empty) + frag, in the same subsegment as the old frag. + [frchain_now remains the same but frag_now is updated.] + Because this calculates the correct value of fr_fix by + looking at the obstack 'frags', it needs to know how many + characters at the end of the old frag belong to the maximal + variable part; The rest must belong to fr_fix. + It doesn't actually set up the old frag's fr_var. You may have + set fr_var == 1, but allocated 10 chars to the end of the frag; + In this case you pass old_frags_var_max_size == 10. + In fact, you may use fr_var for something totally unrelated to the + size of the variable part of the frag; None of the generic frag + handling code makes use of fr_var. + + Make a new frag, initialising some components. Link new frag at end + of frchain_now. */ + +void frag_new (old_frags_var_max_size) /* Number of chars (already allocated on obstack frags) in - variable_length part of frag. */ + variable_length part of frag. */ int old_frags_var_max_size; { fragS *former_last_fragP; @@ -124,7 +120,7 @@ frag_new (old_frags_var_max_size) assert (frag_now->fr_type != 0); /* This will align the obstack so the next struct we allocate on it - will begin at a correct boundary. */ + will begin at a correct boundary. */ obstack_finish (&frchain_now->frch_obstack); frchP = frchain_now; know (frchP); @@ -138,7 +134,7 @@ frag_new (old_frags_var_max_size) /* Generally, frag_now->points to an address rounded up to next alignment. However, characters will add to obstack frags IMMEDIATELY after the struct frag, even if they are not starting - at an alignment address. */ + at an alignment address. */ former_last_fragP->fr_next = frag_now; frchP->frch_last = frag_now; @@ -152,17 +148,13 @@ frag_new (old_frags_var_max_size) assert (frchain_now->frch_last == frag_now); frag_now->fr_next = NULL; -} /* frag_new() */ +} -/* - * frag_more() - * - * Start a new frag unless we have n more chars of room in the current frag. - * Close off the old frag with a .fill 0. - * - * Return the address of the 1st char to write into. Advance - * frag_now_growth past the new chars. - */ +/* Start a new frag unless we have n more chars of room in the current frag. + Close off the old frag with a .fill 0. + + Return the address of the 1st char to write into. Advance + frag_now_growth past the new chars. */ char * frag_more (nchars) @@ -186,18 +178,14 @@ frag_more (nchars) retval = obstack_next_free (&frchain_now->frch_obstack); obstack_blank_fast (&frchain_now->frch_obstack, nchars); return (retval); -} /* frag_more() */ +} -/* - * frag_var() - * - * Start a new frag unless we have max_chars more chars of room in the current frag. - * Close off the old frag with a .fill 0. - * - * Set up a machine_dependent relaxable frag, then start a new frag. - * Return the address of the 1st char of the var part of the old frag - * to write into. - */ +/* Start a new frag unless we have max_chars more chars of room in the + current frag. Close off the old frag with a .fill 0. + + Set up a machine_dependent relaxable frag, then start a new frag. + Return the address of the 1st char of the var part of the old frag + to write into. */ char * frag_var (type, max_chars, var, subtype, symbol, offset, opcode) @@ -233,13 +221,9 @@ frag_var (type, max_chars, var, subtype, symbol, offset, opcode) return (retval); } -/* - * frag_variant() - * - * OVE: This variant of frag_var assumes that space for the tail has been - * allocated by caller. - * No call to frag_grow is done. - */ +/* OVE: This variant of frag_var assumes that space for the tail has been + allocated by caller. + No call to frag_grow is done. */ char * frag_variant (type, max_chars, var, subtype, symbol, offset, opcode) @@ -271,14 +255,11 @@ frag_variant (type, max_chars, var, subtype, symbol, offset, opcode) as_where (&frag_now->fr_file, &frag_now->fr_line); frag_new (max_chars); return (retval); -} /* frag_variant() */ +} -/* - * frag_wane() - * - * Reduce the variable end of a frag to a harmless state. - */ -void +/* Reduce the variable end of a frag to a harmless state. */ + +void frag_wane (fragP) register fragS *fragP; { @@ -294,7 +275,7 @@ frag_wane (fragP) the maximum number of characters to skip when doing the alignment, or 0 if there is no maximum. */ -void +void frag_align (alignment, fill_character, max) int alignment; int fill_character; @@ -305,8 +286,8 @@ frag_align (alignment, fill_character, max) addressT new_off; addressT mask; - mask = (~ (addressT) 0) << alignment; - new_off = (abs_section_offset + ~ mask) & mask; + mask = (~(addressT) 0) << alignment; + new_off = (abs_section_offset + ~mask) & mask; if (max == 0 || new_off - abs_section_offset <= (addressT) max) abs_section_offset = new_off; } @@ -327,7 +308,7 @@ frag_align (alignment, fill_character, max) FILL_PATTERN. MAX is the maximum number of characters to skip when doing the alignment, or 0 if there is no maximum. */ -void +void frag_align_pattern (alignment, fill_pattern, n_fill, max) int alignment; const char *fill_pattern; @@ -347,14 +328,14 @@ frag_now_fix_octets () if (now_seg == absolute_section) return abs_section_offset; - return ((char*) obstack_next_free (&frchain_now->frch_obstack) - - frag_now->fr_literal); + return ((char *) obstack_next_free (&frchain_now->frch_obstack) + - frag_now->fr_literal); } addressT frag_now_fix () { - return frag_now_fix_octets() / OCTETS_PER_BYTE; + return frag_now_fix_octets () / OCTETS_PER_BYTE; } void @@ -368,5 +349,3 @@ frag_append_1_char (datum) } obstack_1grow (&frchain_now->frch_obstack, datum); } - -/* end of frags.c */ diff --git a/gas/macro.c b/gas/macro.c index a8a0ae480d4..c5b9b68e4ee 100644 --- a/gas/macro.c +++ b/gas/macro.c @@ -1,5 +1,6 @@ /* macro.c - macro support for gas and gasp - Copyright (C) 1994, 95, 96, 97, 98, 1999 Free Software Foundation, Inc. + Copyright (C) 1994, 95, 96, 97, 98, 99, 2000 + Free Software Foundation, Inc. Written by Steve and Judy Chamberlain of Cygnus Support, sac@cygnus.com @@ -19,7 +20,7 @@ You should have received a copy of the GNU General Public License along with GAS; see the file COPYING. If not, write to the Free Software Foundation, 59 Temple Place - Suite 330, Boston, MA - 02111-1307, USA. */ + 02111-1307, USA. */ #include "config.h" @@ -172,7 +173,7 @@ buffer_and_nest (from, to, ptr, get_line) while (more) { - /* Try and find the first pseudo op on the line */ + /* Try and find the first pseudo op on the line. */ int i = line_start; if (! macro_alternate && ! macro_mri) @@ -180,26 +181,26 @@ buffer_and_nest (from, to, ptr, get_line) /* With normal syntax we can suck what we want till we get to the dot. With the alternate, labels have to start in the first column, since we cant tell what's a label and - whats a pseudoop */ + whats a pseudoop. */ - /* Skip leading whitespace */ + /* Skip leading whitespace. */ while (i < ptr->len && ISWHITE (ptr->ptr[i])) i++; - /* Skip over a label */ + /* Skip over a label. */ while (i < ptr->len && (isalnum ((unsigned char) ptr->ptr[i]) || ptr->ptr[i] == '_' || ptr->ptr[i] == '$')) i++; - /* And a colon */ + /* And a colon. */ if (i < ptr->len && ptr->ptr[i] == ':') i++; } - /* Skip trailing whitespace */ + /* Skip trailing whitespace. */ while (i < ptr->len && ISWHITE (ptr->ptr[i])) i++; @@ -208,24 +209,26 @@ buffer_and_nest (from, to, ptr, get_line) || macro_mri)) { if (ptr->ptr[i] == '.') - i++; + i++; if (strncasecmp (ptr->ptr + i, from, from_len) == 0 - && (ptr->len == (i + from_len) || ! isalnum (ptr->ptr[i + from_len]))) + && (ptr->len == (i + from_len) + || ! isalnum (ptr->ptr[i + from_len]))) depth++; if (strncasecmp (ptr->ptr + i, to, to_len) == 0 - && (ptr->len == (i + to_len) || ! isalnum (ptr->ptr[i + to_len]))) + && (ptr->len == (i + to_len) + || ! isalnum (ptr->ptr[i + to_len]))) { depth--; if (depth == 0) { - /* Reset the string to not include the ending rune */ + /* Reset the string to not include the ending rune. */ ptr->len = line_start; break; } } } - /* Add a CR to the end and keep running */ + /* Add a CR to the end and keep running. */ sb_add_char (ptr, '\n'); line_start = ptr->len; more = get_line (ptr); @@ -257,7 +260,7 @@ get_token (idx, in, name) sb_add_char (name, in->ptr[idx++]); } } - /* Ignore trailing & */ + /* Ignore trailing &. */ if (macro_alternate && idx < in->len && in->ptr[idx] == '&') idx++; return idx; @@ -274,7 +277,7 @@ getstring (idx, in, acc) idx = sb_skip_white (idx, in); while (idx < in->len - && (in->ptr[idx] == '"' + && (in->ptr[idx] == '"' || (in->ptr[idx] == '<' && (macro_alternate || macro_mri)) || (in->ptr[idx] == '\'' && macro_alternate))) { @@ -287,7 +290,7 @@ getstring (idx, in, acc) { if (in->ptr[idx] == '!') { - idx++ ; + idx++; sb_add_char (acc, in->ptr[idx++]); } else @@ -305,46 +308,46 @@ getstring (idx, in, acc) { char tchar = in->ptr[idx]; int escaped = 0; - + idx++; - + while (idx < in->len) { - if (in->ptr[idx-1] == '\\') + if (in->ptr[idx - 1] == '\\') escaped ^= 1; else escaped = 0; if (macro_alternate && in->ptr[idx] == '!') { - idx ++; - + idx++; + sb_add_char (acc, in->ptr[idx]); - idx ++; + idx++; } else if (escaped && in->ptr[idx] == tchar) { sb_add_char (acc, tchar); - idx ++; + idx++; } else { if (in->ptr[idx] == tchar) { - idx ++; - + idx++; + if (idx >= in->len || in->ptr[idx] != tchar) break; } - + sb_add_char (acc, in->ptr[idx]); - idx ++; + idx++; } } } } - + return idx; } @@ -369,7 +372,7 @@ get_any_string (idx, in, out, expand, pretend_quoted) if (idx < in->len) { - if (in->len > 2 && in->ptr[idx+1] == '\'' && ISBASE (in->ptr[idx])) + if (in->len > 2 && in->ptr[idx + 1] == '\'' && ISBASE (in->ptr[idx])) { while (!ISSEP (in->ptr[idx])) sb_add_char (out, in->ptr[idx++]); @@ -380,7 +383,7 @@ get_any_string (idx, in, out, expand, pretend_quoted) { int val; char buf[20]; - /* Turns the next expression into a string */ + /* Turns the next expression into a string. */ idx = (*macro_expr) (_("% operator needs absolute expression"), idx + 1, in, @@ -396,39 +399,39 @@ get_any_string (idx, in, out, expand, pretend_quoted) && ! macro_strip_at && expand) { - /* Keep the quotes */ - sb_add_char (out, '\"'); + /* Keep the quotes. */ + sb_add_char (out, '\"'); idx = getstring (idx, in, out); - sb_add_char (out, '\"'); + sb_add_char (out, '\"'); } else { idx = getstring (idx, in, out); } } - else + else { - while (idx < in->len + while (idx < in->len && (in->ptr[idx] == '"' || in->ptr[idx] == '\'' - || pretend_quoted + || pretend_quoted || (in->ptr[idx] != ' ' && in->ptr[idx] != '\t' && in->ptr[idx] != ',' && (in->ptr[idx] != '<' || (! macro_alternate && ! macro_mri))))) { - if (in->ptr[idx] == '"' + if (in->ptr[idx] == '"' || in->ptr[idx] == '\'') { char tchar = in->ptr[idx]; sb_add_char (out, in->ptr[idx++]); while (idx < in->len && in->ptr[idx] != tchar) - sb_add_char (out, in->ptr[idx++]); + sb_add_char (out, in->ptr[idx++]); if (idx == in->len) - return idx; + return idx; } sb_add_char (out, in->ptr[idx++]); } @@ -467,15 +470,15 @@ do_formals (macro, idx, in) idx = sb_skip_white (idx, in); if (formal->name.len) { - /* This is a formal */ + /* This is a formal. */ if (idx < in->len && in->ptr[idx] == '=') { - /* Got a default */ + /* Got a default. */ idx = get_any_string (idx + 1, in, &formal->def, 1, 0); } } - /* Add to macro's hash table */ + /* Add to macro's hash table. */ hash_jam (macro->formal_hash, sb_terminate (&formal->name), formal); formal->index = macro->formal_count; @@ -508,7 +511,7 @@ do_formals (macro, idx, in) sb_add_string (&formal->name, name); - /* Add to macro's hash table */ + /* Add to macro's hash table. */ hash_jam (macro->formal_hash, name, formal); formal->index = NARG_INDEX; @@ -550,14 +553,14 @@ define_macro (idx, in, label, get_line, namep) sb_add_sb (&name, label); if (idx < in->len && in->ptr[idx] == '(') { - /* It's the label: MACRO (formals,...) sort */ + /* It's the label: MACRO (formals,...) sort */ idx = do_formals (macro, idx + 1, in); if (in->ptr[idx] != ')') return _("missing ) after formals"); } else { - /* It's the label: MACRO formals,... sort */ + /* It's the label: MACRO formals,... sort */ idx = do_formals (macro, idx, in); } } @@ -568,7 +571,7 @@ define_macro (idx, in, label, get_line, namep) idx = do_formals (macro, idx, in); } - /* and stick it in the macro hash table */ + /* And stick it in the macro hash table. */ for (idx = 0; idx < name.len; idx++) if (isupper ((unsigned char) name.ptr[idx])) name.ptr[idx] = tolower (name.ptr[idx]); @@ -645,7 +648,7 @@ sub_actual (start, in, t, formal_hash, kind, out, copyifnotthere) { sb_add_sb (out, t); } - else + else { sb_add_char (out, '\\'); sb_add_sb (out, t); @@ -694,14 +697,14 @@ macro_expand_body (in, out, formals, formal_hash, comment_char, locals) src++; if (in->ptr[src] == comment_char && comment_char != '\0') { - /* This is a comment, just drop the rest of the line */ + /* This is a comment, just drop the rest of the line. */ while (src < in->len && in->ptr[src] != '\n') src++; } else if (in->ptr[src] == '(') { - /* Sub in till the next ')' literally */ + /* Sub in till the next ')' literally. */ src++; while (src < in->len && in->ptr[src] != ')') { @@ -714,7 +717,7 @@ macro_expand_body (in, out, formals, formal_hash, comment_char, locals) } else if (in->ptr[src] == '@') { - /* Sub in the macro invocation number */ + /* Sub in the macro invocation number. */ char buffer[10]; src++; @@ -724,7 +727,7 @@ macro_expand_body (in, out, formals, formal_hash, comment_char, locals) else if (in->ptr[src] == '&') { /* This is a preprocessor variable name, we don't do them - here */ + here. */ sb_add_char (out, '\\'); sb_add_char (out, '&'); src++; @@ -919,10 +922,10 @@ macro_expand (idx, in, m, out, comment_char) const char *err; sb_new (&t); - - /* Reset any old value the actuals may have */ + + /* Reset any old value the actuals may have. */ for (f = m->formals; f; f = f->next) - sb_reset (&f->actual); + sb_reset (&f->actual); f = m->formals; while (f != NULL && f->index < 0) f = f->next; @@ -948,13 +951,13 @@ macro_expand (idx, in, m, out, comment_char) } } - /* Peel off the actuals and store them away in the hash tables' actuals */ + /* Peel off the actuals and store them away in the hash tables' actuals. */ idx = sb_skip_white (idx, in); while (idx < in->len && in->ptr[idx] != comment_char) { int scan; - /* Look and see if it's a positional or keyword arg */ + /* Look and see if it's a positional or keyword arg. */ scan = idx; while (scan < in->len && !ISSEP (in->ptr[scan]) @@ -968,19 +971,19 @@ macro_expand (idx, in, m, out, comment_char) /* It's OK to go from positional to keyword. */ /* This is a keyword arg, fetch the formal name and - then the actual stuff */ + then the actual stuff. */ sb_reset (&t); idx = get_token (idx, in, &t); if (in->ptr[idx] != '=') return _("confusion in formal parameters"); - /* Lookup the formal in the macro's list */ + /* Lookup the formal in the macro's list. */ ptr = (formal_entry *) hash_find (m->formal_hash, sb_terminate (&t)); if (!ptr) return _("macro formal argument does not exist"); else { - /* Insert this value into the right place */ + /* Insert this value into the right place. */ sb_reset (&ptr->actual); idx = get_any_string (idx + 1, in, &ptr->actual, 0, 0); if (ptr->actual.len > 0) @@ -989,7 +992,7 @@ macro_expand (idx, in, m, out, comment_char) } else { - /* This is a positional arg */ + /* This is a positional arg. */ is_positional = 1; if (is_keyword) return _("can't mix positional and keyword arguments"); @@ -1136,7 +1139,7 @@ check_macro (line, expand, comment_char, error, info) sb_kill (&line_sb); - /* export the macro information if requested */ + /* Export the macro information if requested. */ if (info) *info = macro; @@ -1181,7 +1184,7 @@ expand_irp (irpc, idx, in, out, get_line, comment_char) sb_new (&sub); if (! buffer_and_nest (mn, "ENDR", &sub, get_line)) return _("unexpected end of file in irp or irpc"); - + sb_new (&f.name); sb_new (&f.def); sb_new (&f.actual); -- 2.34.1