From 29e8be2efc13e36fb7cce4df4825371bdabe1efb Mon Sep 17 00:00:00 2001
From: Sangchul Lee <sc11.lee@samsung.com>
Date: Mon, 3 Jan 2022 18:31:31 +0900
Subject: [PATCH] [webrtc] Add items for FEC setting

'fec percentage' is added to set the value to ulpfec encoder.

'use inbandfec' and 'packet loss percentage' are added for in-band FEC
which are only supported by opusenc. The in-band FEC is now enabled
for audio sources by this patch.

[Version] 0.3.34
[Issue Type] Add

Change-Id: I29110c6c39c54884dad5122e0c7adc3b5bb80adf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
---
 .../hal/etc/multimedia/mmfw_webrtc.ini              | 13 ++++++++++---
 .../hal/etc/multimedia/mmfw_webrtc.ini              | 13 ++++++++++---
 .../hal/etc/multimedia/mmfw_webrtc.ini              | 13 ++++++++++---
 .../hal/etc/multimedia/mmfw_webrtc.ini              | 13 ++++++++++---
 .../hal/etc/multimedia/mmfw_webrtc.ini              | 13 ++++++++++---
 .../hal/etc/multimedia/mmfw_webrtc.ini              | 13 ++++++++++---
 .../hal/etc/multimedia/mmfw_webrtc.ini              | 13 ++++++++++---
 .../hal/etc/multimedia/mmfw_webrtc.ini              | 13 ++++++++++---
 .../hal/etc/multimedia/mmfw_webrtc.ini              | 13 ++++++++++---
 .../hal/etc/multimedia/mmfw_webrtc.ini              | 13 ++++++++++---
 packaging/media-config.spec                         |  2 +-
 11 files changed, 101 insertions(+), 31 deletions(-)

diff --git a/media-config-simulator/hal/etc/multimedia/mmfw_webrtc.ini b/media-config-simulator/hal/etc/multimedia/mmfw_webrtc.ini
index ce2c763..8c77a65 100644
--- a/media-config-simulator/hal/etc/multimedia/mmfw_webrtc.ini
+++ b/media-config-simulator/hal/etc/multimedia/mmfw_webrtc.ini
@@ -48,7 +48,11 @@ audio channels = 1
 audio codec = opus
 audio hw encoder element =
 ; default FEC setting of RTP packets
-use ulpfec red = yes
+use ulpfec red = no
+fec percentage = 100
+; default in-band FEC setting (only supported by opusenc/opusdec)
+use inbandfec = no
+packet loss percentage = 10
 
 
 [source videotest]
@@ -64,6 +68,7 @@ source element properties = is-live=1,pattern=18
 ;video hw encoder element =
 ;video encoded format support =
 video drc support = yes
+use ulpfec red = yes
 
 
 [source camera]
@@ -79,6 +84,7 @@ source element properties = is-live=1
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source screen]
@@ -94,6 +100,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source audiotest]
@@ -106,7 +113,7 @@ source element properties = is-live=1
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [source mic]
@@ -119,7 +126,7 @@ source element properties =
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [rendering sink]
diff --git a/media-config-target-artik10/hal/etc/multimedia/mmfw_webrtc.ini b/media-config-target-artik10/hal/etc/multimedia/mmfw_webrtc.ini
index 3b39d57..61ac4e5 100644
--- a/media-config-target-artik10/hal/etc/multimedia/mmfw_webrtc.ini
+++ b/media-config-target-artik10/hal/etc/multimedia/mmfw_webrtc.ini
@@ -48,7 +48,11 @@ audio channels = 1
 audio codec = opus
 audio hw encoder element =
 ; default FEC setting of RTP packets
-use ulpfec red = yes
+use ulpfec red = no
+fec percentage = 100
+; default in-band FEC setting (only supported by opusenc/opusdec)
+use inbandfec = no
+packet loss percentage = 10
 
 
 [source videotest]
@@ -64,6 +68,7 @@ source element properties = is-live=1,pattern=18
 ;video hw encoder element =
 ;video encoded format support =
 video drc support = yes
+use ulpfec red = yes
 
 
 [source camera]
@@ -79,6 +84,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source screen]
@@ -94,6 +100,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source audiotest]
@@ -106,7 +113,7 @@ source element properties = is-live=1
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [source mic]
@@ -119,7 +126,7 @@ source element properties =
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [rendering sink]
diff --git a/media-config-target-c4/hal/etc/multimedia/mmfw_webrtc.ini b/media-config-target-c4/hal/etc/multimedia/mmfw_webrtc.ini
index f356ebb..88fe4f2 100644
--- a/media-config-target-c4/hal/etc/multimedia/mmfw_webrtc.ini
+++ b/media-config-target-c4/hal/etc/multimedia/mmfw_webrtc.ini
@@ -48,7 +48,11 @@ audio channels = 1
 audio codec = opus
 audio hw encoder element =
 ; default FEC setting of RTP packets
-use ulpfec red = yes
+use ulpfec red = no
+fec percentage = 100
+; default in-band FEC setting (only supported by opusenc/opusdec)
+use inbandfec = no
+packet loss percentage = 10
 
 
 [source videotest]
@@ -64,6 +68,7 @@ source element properties = is-live=1,pattern=18
 ;video hw encoder element =
 ;video encoded format support =
 video drc support = yes
+use ulpfec red = yes
 
 
 [source camera]
@@ -79,6 +84,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source screen]
@@ -94,6 +100,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source audiotest]
@@ -106,7 +113,7 @@ source element properties = is-live=1
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [source mic]
@@ -119,7 +126,7 @@ source element properties =
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [rendering sink]
diff --git a/media-config-target-qrb2210/hal/etc/multimedia/mmfw_webrtc.ini b/media-config-target-qrb2210/hal/etc/multimedia/mmfw_webrtc.ini
index f356ebb..88fe4f2 100644
--- a/media-config-target-qrb2210/hal/etc/multimedia/mmfw_webrtc.ini
+++ b/media-config-target-qrb2210/hal/etc/multimedia/mmfw_webrtc.ini
@@ -48,7 +48,11 @@ audio channels = 1
 audio codec = opus
 audio hw encoder element =
 ; default FEC setting of RTP packets
-use ulpfec red = yes
+use ulpfec red = no
+fec percentage = 100
+; default in-band FEC setting (only supported by opusenc/opusdec)
+use inbandfec = no
+packet loss percentage = 10
 
 
 [source videotest]
@@ -64,6 +68,7 @@ source element properties = is-live=1,pattern=18
 ;video hw encoder element =
 ;video encoded format support =
 video drc support = yes
+use ulpfec red = yes
 
 
 [source camera]
@@ -79,6 +84,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source screen]
@@ -94,6 +100,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source audiotest]
@@ -106,7 +113,7 @@ source element properties = is-live=1
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [source mic]
@@ -119,7 +126,7 @@ source element properties =
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [rendering sink]
diff --git a/media-config-target-rb5/hal/etc/multimedia/mmfw_webrtc.ini b/media-config-target-rb5/hal/etc/multimedia/mmfw_webrtc.ini
index f356ebb..88fe4f2 100644
--- a/media-config-target-rb5/hal/etc/multimedia/mmfw_webrtc.ini
+++ b/media-config-target-rb5/hal/etc/multimedia/mmfw_webrtc.ini
@@ -48,7 +48,11 @@ audio channels = 1
 audio codec = opus
 audio hw encoder element =
 ; default FEC setting of RTP packets
-use ulpfec red = yes
+use ulpfec red = no
+fec percentage = 100
+; default in-band FEC setting (only supported by opusenc/opusdec)
+use inbandfec = no
+packet loss percentage = 10
 
 
 [source videotest]
@@ -64,6 +68,7 @@ source element properties = is-live=1,pattern=18
 ;video hw encoder element =
 ;video encoded format support =
 video drc support = yes
+use ulpfec red = yes
 
 
 [source camera]
@@ -79,6 +84,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source screen]
@@ -94,6 +100,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source audiotest]
@@ -106,7 +113,7 @@ source element properties = is-live=1
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [source mic]
@@ -119,7 +126,7 @@ source element properties =
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [rendering sink]
diff --git a/media-config-target-rpi3-spk/hal/etc/multimedia/mmfw_webrtc.ini b/media-config-target-rpi3-spk/hal/etc/multimedia/mmfw_webrtc.ini
index f356ebb..88fe4f2 100644
--- a/media-config-target-rpi3-spk/hal/etc/multimedia/mmfw_webrtc.ini
+++ b/media-config-target-rpi3-spk/hal/etc/multimedia/mmfw_webrtc.ini
@@ -48,7 +48,11 @@ audio channels = 1
 audio codec = opus
 audio hw encoder element =
 ; default FEC setting of RTP packets
-use ulpfec red = yes
+use ulpfec red = no
+fec percentage = 100
+; default in-band FEC setting (only supported by opusenc/opusdec)
+use inbandfec = no
+packet loss percentage = 10
 
 
 [source videotest]
@@ -64,6 +68,7 @@ source element properties = is-live=1,pattern=18
 ;video hw encoder element =
 ;video encoded format support =
 video drc support = yes
+use ulpfec red = yes
 
 
 [source camera]
@@ -79,6 +84,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source screen]
@@ -94,6 +100,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source audiotest]
@@ -106,7 +113,7 @@ source element properties = is-live=1
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [source mic]
@@ -119,7 +126,7 @@ source element properties =
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [rendering sink]
diff --git a/media-config-target-rpi3/hal/etc/multimedia/mmfw_webrtc.ini b/media-config-target-rpi3/hal/etc/multimedia/mmfw_webrtc.ini
index f356ebb..88fe4f2 100644
--- a/media-config-target-rpi3/hal/etc/multimedia/mmfw_webrtc.ini
+++ b/media-config-target-rpi3/hal/etc/multimedia/mmfw_webrtc.ini
@@ -48,7 +48,11 @@ audio channels = 1
 audio codec = opus
 audio hw encoder element =
 ; default FEC setting of RTP packets
-use ulpfec red = yes
+use ulpfec red = no
+fec percentage = 100
+; default in-band FEC setting (only supported by opusenc/opusdec)
+use inbandfec = no
+packet loss percentage = 10
 
 
 [source videotest]
@@ -64,6 +68,7 @@ source element properties = is-live=1,pattern=18
 ;video hw encoder element =
 ;video encoded format support =
 video drc support = yes
+use ulpfec red = yes
 
 
 [source camera]
@@ -79,6 +84,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source screen]
@@ -94,6 +100,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source audiotest]
@@ -106,7 +113,7 @@ source element properties = is-live=1
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [source mic]
@@ -119,7 +126,7 @@ source element properties =
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [rendering sink]
diff --git a/media-config-target-tm1/hal/etc/multimedia/mmfw_webrtc.ini b/media-config-target-tm1/hal/etc/multimedia/mmfw_webrtc.ini
index e675e47..0c07537 100644
--- a/media-config-target-tm1/hal/etc/multimedia/mmfw_webrtc.ini
+++ b/media-config-target-tm1/hal/etc/multimedia/mmfw_webrtc.ini
@@ -48,7 +48,11 @@ audio channels = 1
 audio codec = opus
 audio hw encoder element =
 ; default FEC setting of RTP packets
-use ulpfec red = yes
+use ulpfec red = no
+fec percentage = 100
+; default in-band FEC setting (only supported by opusenc/opusdec)
+use inbandfec = no
+packet loss percentage = 10
 
 
 [source videotest]
@@ -64,6 +68,7 @@ source element properties = is-live=1,pattern=18
 ;video hw encoder element =
 ;video encoded format support =
 video drc support = yes
+use ulpfec red = yes
 
 
 [source camera]
@@ -79,6 +84,7 @@ video codec = h264
 video hw encoder element = sprdenc_h264
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source screen]
@@ -94,6 +100,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source audiotest]
@@ -106,7 +113,7 @@ source element properties = is-live=1
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [source mic]
@@ -119,7 +126,7 @@ source element properties =
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [rendering sink]
diff --git a/media-config-target-tw3/hal/etc/multimedia/mmfw_webrtc.ini b/media-config-target-tw3/hal/etc/multimedia/mmfw_webrtc.ini
index ce2c763..8c77a65 100644
--- a/media-config-target-tw3/hal/etc/multimedia/mmfw_webrtc.ini
+++ b/media-config-target-tw3/hal/etc/multimedia/mmfw_webrtc.ini
@@ -48,7 +48,11 @@ audio channels = 1
 audio codec = opus
 audio hw encoder element =
 ; default FEC setting of RTP packets
-use ulpfec red = yes
+use ulpfec red = no
+fec percentage = 100
+; default in-band FEC setting (only supported by opusenc/opusdec)
+use inbandfec = no
+packet loss percentage = 10
 
 
 [source videotest]
@@ -64,6 +68,7 @@ source element properties = is-live=1,pattern=18
 ;video hw encoder element =
 ;video encoded format support =
 video drc support = yes
+use ulpfec red = yes
 
 
 [source camera]
@@ -79,6 +84,7 @@ source element properties = is-live=1
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source screen]
@@ -94,6 +100,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source audiotest]
@@ -106,7 +113,7 @@ source element properties = is-live=1
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [source mic]
@@ -119,7 +126,7 @@ source element properties =
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [rendering sink]
diff --git a/media-config-target-vim3/hal/etc/multimedia/mmfw_webrtc.ini b/media-config-target-vim3/hal/etc/multimedia/mmfw_webrtc.ini
index f356ebb..88fe4f2 100644
--- a/media-config-target-vim3/hal/etc/multimedia/mmfw_webrtc.ini
+++ b/media-config-target-vim3/hal/etc/multimedia/mmfw_webrtc.ini
@@ -48,7 +48,11 @@ audio channels = 1
 audio codec = opus
 audio hw encoder element =
 ; default FEC setting of RTP packets
-use ulpfec red = yes
+use ulpfec red = no
+fec percentage = 100
+; default in-band FEC setting (only supported by opusenc/opusdec)
+use inbandfec = no
+packet loss percentage = 10
 
 
 [source videotest]
@@ -64,6 +68,7 @@ source element properties = is-live=1,pattern=18
 ;video hw encoder element =
 ;video encoded format support =
 video drc support = yes
+use ulpfec red = yes
 
 
 [source camera]
@@ -79,6 +84,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source screen]
@@ -94,6 +100,7 @@ source element properties =
 ;video hw encoder element =
 ;video encoded format support =
 ;video drc support =
+use ulpfec red = yes
 
 
 [source audiotest]
@@ -106,7 +113,7 @@ source element properties = is-live=1
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [source mic]
@@ -119,7 +126,7 @@ source element properties =
 ;audio channels =
 ;audio codec =
 ;audio hw encoder element =
-use ulpfec red = no
+use inbandfec = yes
 
 
 [rendering sink]
diff --git a/packaging/media-config.spec b/packaging/media-config.spec
index 3b43897..096a811 100644
--- a/packaging/media-config.spec
+++ b/packaging/media-config.spec
@@ -1,6 +1,6 @@
 Name:       media-config
 Summary:    Multimedia Framework system configuration package
-Version:    0.3.33
+Version:    0.3.34
 Release:    0
 Group:      Multimedia/Configuration
 License:    LGPL-2.1 and Apache-2.0
-- 
2.34.1