From 29e355d0d671c7474935220e8bef784f05143820 Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Fri, 8 Apr 2022 18:04:04 +0100 Subject: [PATCH] libstdc++: Fix std::bad_expected_access constructor [PR105146] libstdc++-v3/ChangeLog: PR libstdc++/105146 * include/std/expected (bad_expected_access): Move constructor parameter. * testsuite/20_util/expected/bad.cc: New test. --- libstdc++-v3/include/std/expected | 2 +- libstdc++-v3/testsuite/20_util/expected/bad.cc | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 libstdc++-v3/testsuite/20_util/expected/bad.cc diff --git a/libstdc++-v3/include/std/expected b/libstdc++-v3/include/std/expected index 39d07cd..7b01a17 100644 --- a/libstdc++-v3/include/std/expected +++ b/libstdc++-v3/include/std/expected @@ -95,7 +95,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION class bad_expected_access : public bad_expected_access { public: explicit - bad_expected_access(_Er __e) : _M_val(__e) { } + bad_expected_access(_Er __e) : _M_val(std::move(__e)) { } // XXX const char* what() const noexcept override; diff --git a/libstdc++-v3/testsuite/20_util/expected/bad.cc b/libstdc++-v3/testsuite/20_util/expected/bad.cc new file mode 100644 index 0000000..17bc6d6 --- /dev/null +++ b/libstdc++-v3/testsuite/20_util/expected/bad.cc @@ -0,0 +1,15 @@ +// { dg-options "-std=gnu++23" } +// { dg-do compile } + +#include + +struct E { + E() = default; + E(E&&) = default; +}; + +void +test_pr105146() +{ + std::bad_expected_access(E{}); +} -- 2.7.4