From 29b77aef6733a2e0731b702db11dce9d494825bd Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Fri, 2 Mar 2012 09:53:10 +0100 Subject: [PATCH] Bug #658742 - Gettext messages require translator comments --- addressbook/libebook/e-contact.c | 20 +++++++++++++++++--- libedataserver/e-client.c | 2 ++ 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/addressbook/libebook/e-contact.c b/addressbook/libebook/e-contact.c index 296b696..292f199 100644 --- a/addressbook/libebook/e-contact.c +++ b/addressbook/libebook/e-contact.c @@ -120,8 +120,10 @@ static const EContactFieldInfo field_info[] = { {0,}, /* Dummy row as EContactField starts from 1 */ STRING_FIELD (E_CONTACT_UID, EVC_UID, "id", N_("Unique ID"), FALSE), /* FILE_AS is not really a structured field - we use a getter/setter - * so we can generate its value if necessary in the getter */ - GETSET_FIELD (E_CONTACT_FILE_AS, EVC_X_FILE_AS, "file_as", N_("File Under"), FALSE, fileas_getter, fileas_setter), + * so we can generate its value if necessary in the getter */ + /* Translators: This is an EContact field description, in this case it's a + preferred user's description (or display name) of the contact. Note 'File' is a verb here. */ + GETSET_FIELD (E_CONTACT_FILE_AS, EVC_X_FILE_AS, "file_as", N_("File Under"), FALSE, fileas_getter, fileas_setter), /* URI of the book to which the contact belongs to */ STRING_FIELD (E_CONTACT_BOOK_URI, EVC_X_BOOK_URI, "book_uri", N_("Book URI"), FALSE), @@ -235,6 +237,9 @@ static const EContactFieldInfo field_info[] = { /* Last modified time */ STRING_FIELD (E_CONTACT_REV, EVC_REV, "Rev", N_("Last Revision"), FALSE), + /* Translators: This is an EContact field description, in this case it's a + virtual field, which returns either name of the contact or the organization + name, recognized by multiple other fields, where the first filled is used. */ SYNTH_STR_FIELD (E_CONTACT_NAME_OR_ORG, "name_or_org", N_("Name or Org"), TRUE), /* Address fields */ @@ -250,7 +255,9 @@ static const EContactFieldInfo field_info[] = { STRUCT_FIELD (E_CONTACT_PHOTO, EVC_PHOTO, "photo", N_("Photo"), FALSE, photo_getter, photo_setter, e_contact_photo_get_type), STRUCT_FIELD (E_CONTACT_LOGO, EVC_LOGO, "logo", N_("Logo"), FALSE, photo_getter, photo_setter, e_contact_photo_get_type), - STRUCT_FIELD (E_CONTACT_NAME, EVC_N, "name", N_("Name"), FALSE, n_getter, n_setter, e_contact_name_get_type), + /* Translators: This is an EContact field description, in this case it's a name + of the contact, as specified in http://tools.ietf.org/html/rfc6350#section-6.2.2 */ + STRUCT_FIELD (E_CONTACT_NAME, EVC_N, "name", N_("Name"), FALSE, n_getter, n_setter, e_contact_name_get_type), MULTI_LIST_FIELD (E_CONTACT_EMAIL, EVC_EMAIL, "email", N_("Email List"), FALSE), /* Instant messaging fields */ @@ -263,7 +270,14 @@ static const EContactFieldInfo field_info[] = { BOOLEAN_FIELD (E_CONTACT_WANTS_HTML, EVC_X_WANTS_HTML, "wants_html", N_("Wants HTML Mail"), FALSE), + /* Translators: This is an EContact field description, in this case it's a + field describing whether it's a Contact list (list of email addresses) or a + regular contact for one person/organization/... */ BOOLEAN_FIELD (E_CONTACT_IS_LIST, EVC_X_LIST, "list", N_("List"), FALSE), + /* Translators: This is an EContact field description, in this case it's a flag + used to determine whether when sending to Contact lists the addresses should be + shown or not to other recipients - basically whether to use BCC field or CC + message header when sending messages to this Contact list. */ BOOLEAN_FIELD (E_CONTACT_LIST_SHOW_ADDRESSES, EVC_X_LIST_SHOW_ADDRESSES, "list_show_addresses", N_("List Show Addresses"), FALSE), STRUCT_FIELD (E_CONTACT_BIRTH_DATE, EVC_BDAY, "birth_date", N_("Birth Date"), FALSE, date_getter, date_setter, e_contact_date_get_type), diff --git a/libedataserver/e-client.c b/libedataserver/e-client.c index ce354d8..0f58720 100644 --- a/libedataserver/e-client.c +++ b/libedataserver/e-client.c @@ -132,6 +132,8 @@ e_client_error_to_string (EClientError code) case E_CLIENT_ERROR_REPOSITORY_OFFLINE: return _("Repository offline"); case E_CLIENT_ERROR_OFFLINE_UNAVAILABLE: + /* Translators: This means that the EClient does not support offline mode, or + it's not set to by a user, thus it is unavailable while user is not connected. */ return _("Offline unavailable"); case E_CLIENT_ERROR_PERMISSION_DENIED: return _("Permission denied"); -- 2.7.4