From 2986545ccd655273658e0e4463a669bb1893ba68 Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Wed, 30 Jan 2013 01:11:46 -0600 Subject: [PATCH] btrfs-progs: initialize pipefd[] for error path Several goto out; paths will end up doing i.e. if (pipefd[0]) close(pipefd[0]); but we get there with uninitialized values in many cases. Signed-off-by: Eric Sandeen --- cmds-send.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmds-send.c b/cmds-send.c index 69e9bcea..b2a340e0 100644 --- a/cmds-send.c +++ b/cmds-send.c @@ -245,7 +245,7 @@ static int do_send(struct btrfs_send *send, u64 root_id, u64 parent_root_id) struct subvol_info *si; void *t_err = NULL; int subvol_fd = -1; - int pipefd[2]; + int pipefd[2] = {-1, -1}; si = subvol_uuid_search(&send->sus, root_id, NULL, 0, NULL, subvol_search_by_root_id); @@ -327,9 +327,9 @@ static int do_send(struct btrfs_send *send, u64 root_id, u64 parent_root_id) out: if (subvol_fd != -1) close(subvol_fd); - if (pipefd[0]) + if (pipefd[0] != -1) close(pipefd[0]); - if (pipefd[1]) + if (pipefd[1] != -1) close(pipefd[1]); return ret; } -- 2.34.1