From 289a6840c1ed80f71d58632bb6d702d97d114387 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 2 Oct 2017 11:00:30 +0200 Subject: [PATCH] nto & lynx x86: call init_target_desc In gdbserver, target descriptions need to be initialized by calling init_target_desc. Because i386_create_target_description is shared with GDB, it doesn't do that, the callers must take care of it. These two platforms currently don't. I am not able to build them, so I couldn't test. gdb/gdbserver/ChangeLog: * lynx-i386-low.c (lynx_i386_arch_setup): Call init_target_desc. * nto-x86-low.c (nto_x86_arch_setup): Likewise. --- gdb/gdbserver/ChangeLog | 5 +++++ gdb/gdbserver/lynx-i386-low.c | 7 ++++++- gdb/gdbserver/nto-x86-low.c | 7 ++++++- 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 6027c7f..67223a0 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2017-10-02 Simon Marchi + + * lynx-i386-low.c (lynx_i386_arch_setup): Call init_target_desc. + * nto-x86-low.c (nto_x86_arch_setup): Likewise. + 2017-09-29 Pedro Alves * ax.c (gdb_parse_agent_expr): Constify. diff --git a/gdb/gdbserver/lynx-i386-low.c b/gdb/gdbserver/lynx-i386-low.c index 57181d6..a7eae1d 100644 --- a/gdb/gdbserver/lynx-i386-low.c +++ b/gdb/gdbserver/lynx-i386-low.c @@ -293,7 +293,12 @@ lynx_i386_store_fpregset (struct regcache *regcache, const char *buf) static void lynx_i386_arch_setup (void) { - lynx_tdesc = i386_create_target_description (X86_XSTATE_SSE_MASK, false); + struct target_desc *tdesc + = i386_create_target_description (X86_XSTATE_SSE_MASK, false); + + init_target_desc (tdesc); + + lynx_tdesc = tdesc; } /* Description of all the x86-lynx register sets. */ diff --git a/gdb/gdbserver/nto-x86-low.c b/gdb/gdbserver/nto-x86-low.c index cfa5993..48bdc53 100644 --- a/gdb/gdbserver/nto-x86-low.c +++ b/gdb/gdbserver/nto-x86-low.c @@ -87,7 +87,12 @@ static void nto_x86_arch_setup (void) { the_low_target.num_regs = 16; - nto_tdesc = i386_create_target_description (X86_XSTATE_SSE_MASK, false); + struct target_desc *tdesc + = i386_create_target_description (X86_XSTATE_SSE_MASK, false); + + init_target_desc (tdesc); + + nto_tdesc = tdesc; } struct nto_target_ops the_low_target = -- 2.7.4