From 2889c8a32381ab2ba6e97e6b69646126014c5944 Mon Sep 17 00:00:00 2001 From: Jeff Leger Date: Tue, 25 Jun 2019 17:19:33 -0400 Subject: [PATCH] Fix derivate dynamic tests to check shader stage support The tests used subgroup ballot operations but didnt check if the fragment shader stage was supported. This lead the application to run unsupported tests. Affects: dEQP-VK.glsl.derivate.* Components: Vulkan VK-GL-CTS issue: 1852 Change-Id: I43b80dc03d0944c407cd86b1df4ae0b9a633c680 --- .../modules/vulkan/shaderrender/vktShaderRenderDerivateTests.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderDerivateTests.cpp b/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderDerivateTests.cpp index 6cfd71c..555b798 100644 --- a/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderDerivateTests.cpp +++ b/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderDerivateTests.cpp @@ -700,6 +700,9 @@ tcu::TestStatus TriangleDerivateCaseInstance::iterate (void) if ((subgroupProperties.supportedOperations & VK_SUBGROUP_FEATURE_BALLOT_BIT) == 0) throw tcu::NotSupportedError("Derivative dynamic control flow tests require VK_SUBGROUP_FEATURE_BALLOT_BIT"); + + if ((subgroupProperties.supportedStages & VK_SHADER_STAGE_FRAGMENT_BIT) == 0) + throw tcu::NotSupportedError("Derivative dynamic control flow tests require subgroup supported stage including VK_SHADER_STAGE_FRAGMENT_BIT"); } setup(); -- 2.7.4