From 2815429d08fec06027c4adf81c0b438fb2c72ef0 Mon Sep 17 00:00:00 2001 From: Roman Lebedev Date: Thu, 16 Jul 2020 00:27:36 +0300 Subject: [PATCH] [NFC][SimplifyCFG] HoistThenElseCodeToIf(): after hoisting terminator, do return Changed, not just true Otherwise, if Changed was still false before that, we would not account for that hoist in NumHoistCommonCode statistic. --- llvm/lib/Transforms/Utils/SimplifyCFG.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/llvm/lib/Transforms/Utils/SimplifyCFG.cpp b/llvm/lib/Transforms/Utils/SimplifyCFG.cpp index 94445fe..5aa929f 100644 --- a/llvm/lib/Transforms/Utils/SimplifyCFG.cpp +++ b/llvm/lib/Transforms/Utils/SimplifyCFG.cpp @@ -1422,6 +1422,7 @@ HoistTerminator: I2->replaceAllUsesWith(NT); NT->takeName(I1); } + Changed = true; ++NumHoistCommonInstrs; // Ensure terminator gets a debug location, even an unknown one, in case @@ -1469,7 +1470,7 @@ HoistTerminator: AddPredecessorToBlock(Succ, BIParent, BB1); EraseTerminatorAndDCECond(BI); - return true; + return Changed; } // Check lifetime markers. -- 2.7.4