From 278a6c952b3276e7db61f578ab66f067064cad36 Mon Sep 17 00:00:00 2001 From: Adrian McCarthy Date: Wed, 9 Dec 2015 00:29:38 +0000 Subject: [PATCH] Fix DoReadMemory for Windows mini dumps. Differential Revision: http://reviews.llvm.org/D15359 llvm-svn: 255083 --- lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp b/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp index ca41dac..fbc96f0 100644 --- a/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp +++ b/lldb/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp @@ -30,6 +30,7 @@ #include "lldb/Target/StopInfo.h" #include "lldb/Target/Target.h" #include "lldb/Target/UnixSignals.h" +#include "lldb/Utility/LLDBAssert.h" #include "llvm/Support/ConvertUTF.h" #include "llvm/Support/Format.h" #include "llvm/Support/raw_ostream.h" @@ -267,7 +268,9 @@ ProcessWinMiniDump::DoReadMemory(lldb::addr_t addr, void *buf, size_t size, Erro // There's at least some overlap between the beginning of the desired range // (addr) and the current range. Figure out where the overlap begins and // how much overlap there is, then copy it to the destination buffer. - const size_t offset = range.start - addr; + lldbassert(range.start <= addr); + const size_t offset = addr - range.start; + lldbassert(offset < range.size); const size_t overlap = std::min(size, range.size - offset); std::memcpy(buf, range.ptr + offset, overlap); return overlap; -- 2.7.4