From 27206618d732d026de4d254aad0865515bc8a7fb Mon Sep 17 00:00:00 2001 From: "E.Z. Hart" Date: Thu, 12 Jan 2017 16:33:21 -0700 Subject: [PATCH] Fix test failures in Release mode --- Xamarin.Forms.Core.UnitTests/MessagingCenterTests.cs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/Xamarin.Forms.Core.UnitTests/MessagingCenterTests.cs b/Xamarin.Forms.Core.UnitTests/MessagingCenterTests.cs index 12f2fea..ae16fce 100644 --- a/Xamarin.Forms.Core.UnitTests/MessagingCenterTests.cs +++ b/Xamarin.Forms.Core.UnitTests/MessagingCenterTests.cs @@ -6,6 +6,8 @@ namespace Xamarin.Forms.Core.UnitTests [TestFixture] public class MessagingCenterTests : BaseTestFixture { + TestSubcriber _subscriber; + [Test] public void SingleSubscriber () { @@ -285,9 +287,9 @@ namespace Xamarin.Forms.Core.UnitTests { int i = 4; - var subscriber = new TestSubcriber(); + _subscriber = new TestSubcriber(); // Using a class member so it doesn't get optimized away in Release build - MessagingCenter.Subscribe(subscriber, "test", p => MessagingCenterTestsCallbackSource.Increment(ref i)); + MessagingCenter.Subscribe(_subscriber, "test", p => MessagingCenterTestsCallbackSource.Increment(ref i)); GC.Collect(); GC.WaitForPendingFinalizers(); @@ -295,7 +297,7 @@ namespace Xamarin.Forms.Core.UnitTests var pub = new TestPublisher(); pub.Test(); - Assert.IsTrue(i == 5, "The static method should have incremented 'i'"); + Assert.IsTrue(i == 5, "The static method should have incremented 'i'"); } [Test] @@ -303,10 +305,10 @@ namespace Xamarin.Forms.Core.UnitTests { var success = false; - var subscriber = new TestSubcriber(); - + _subscriber = new TestSubcriber(); // Using a class member so it doesn't get optimized away in Release build + var source = new MessagingCenterTestsCallbackSource(); - MessagingCenter.Subscribe(subscriber, "test", p => source.SuccessCallback(ref success)); + MessagingCenter.Subscribe(_subscriber, "test", p => source.SuccessCallback(ref success)); GC.Collect(); GC.WaitForPendingFinalizers(); -- 2.7.4