From 2709786bdef88ab5ee63ade9411a04362b3feb44 Mon Sep 17 00:00:00 2001 From: Arvind Yadav Date: Fri, 29 Apr 2022 17:58:02 +0530 Subject: [PATCH] nir: Add a lowering pass for polygon and line smoothing MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When poly_line smoothing is enabled then this lowering pass will modify the alpha component of every write to fragment output using sample coverage mask. Reviewed-by: Marek Olšák Reviewed-by: Jason Ekstrand Part-of: --- src/compiler/nir/meson.build | 1 + src/compiler/nir/nir.h | 3 + src/compiler/nir/nir_lower_poly_line_smooth.c | 79 +++++++++++++++++++++++++++ 3 files changed, 83 insertions(+) create mode 100644 src/compiler/nir/nir_lower_poly_line_smooth.c diff --git a/src/compiler/nir/meson.build b/src/compiler/nir/meson.build index 14b1a53..337f29a 100644 --- a/src/compiler/nir/meson.build +++ b/src/compiler/nir/meson.build @@ -187,6 +187,7 @@ files_libnir = files( 'nir_lower_pntc_ytransform.c', 'nir_lower_point_size.c', 'nir_lower_point_size_mov.c', + 'nir_lower_poly_line_smooth.c', 'nir_lower_printf.c', 'nir_lower_regs_to_ssa.c', 'nir_lower_readonly_images_to_tex.c', diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index a25dea1..34f2f21 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -5680,6 +5680,9 @@ nir_opt_preamble(nir_shader *shader, nir_function_impl *nir_shader_get_preamble(nir_shader *shader); +bool +nir_lower_poly_line_smooth(nir_shader *shader, unsigned num_smooth_aa_sample); + #include "nir_inline_helpers.h" #ifdef __cplusplus diff --git a/src/compiler/nir/nir_lower_poly_line_smooth.c b/src/compiler/nir/nir_lower_poly_line_smooth.c new file mode 100644 index 0000000..f09fe21 --- /dev/null +++ b/src/compiler/nir/nir_lower_poly_line_smooth.c @@ -0,0 +1,79 @@ +/* + * Copyright © 2022 Advanced Micro Devices, Inc. + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + */ + +#include "nir.h" +#include "nir_builder.h" + +/** + * This NIR lowers pass for polygon and line smoothing by modifying the alpha + * value of fragment outputs using the sample coverage mask. + */ + +static bool +lower_polylinesmooth(nir_builder *b, nir_instr *instr, void *data) +{ + unsigned *num_smooth_aa_sample = data; + + if (instr->type != nir_instr_type_intrinsic) + return false; + + nir_intrinsic_instr *intr = nir_instr_as_intrinsic(instr); + + if (intr->intrinsic != nir_intrinsic_store_output) + return false; + + int location = nir_intrinsic_io_semantics(intr).location; + if ((location != FRAG_RESULT_COLOR && location < FRAG_RESULT_DATA0) || + nir_intrinsic_src_type(intr) != nir_type_float32) + return false; + + assert(intr->src[0].is_ssa); + assert(intr->num_components == 4); + + b->cursor = nir_before_instr(&intr->instr); + + nir_ssa_def *coverage = nir_load_sample_mask_in(b); + + /* coverage = (coverage) / SI_NUM_SMOOTH_AA_SAMPLES */ + coverage = nir_bit_count(b, coverage); + coverage = nir_u2f32(b, coverage); + coverage = nir_fmul_imm(b, coverage, 1.0 / *num_smooth_aa_sample); + + /* Write out the fragment color*vec4(1, 1, 1, alpha) */ + nir_ssa_def *one = nir_imm_float(b, 1.0f); + nir_ssa_def *new_val = nir_fmul(b, nir_vec4(b, one, one, one, coverage), + intr->src[0].ssa); + nir_instr_rewrite_src(instr, &intr->src[0], nir_src_for_ssa(new_val)); + + return true; +} + +bool +nir_lower_poly_line_smooth(nir_shader *shader, unsigned num_smooth_aa_sample) +{ + assert(shader->info.stage == MESA_SHADER_FRAGMENT); + return nir_shader_instructions_pass(shader, lower_polylinesmooth, + nir_metadata_loop_analysis | + nir_metadata_block_index | + nir_metadata_dominance, &num_smooth_aa_sample); +} -- 2.7.4