From 26bd240a59cb2ab5291e78f0a858110435d4e168 Mon Sep 17 00:00:00 2001 From: Mark Nauwelaerts Date: Sun, 21 Apr 2019 17:17:14 +0200 Subject: [PATCH] srt: post error when failing to start ... as appropriate for a subsequent state change failure --- ext/srt/gstsrtsink.c | 4 +++- ext/srt/gstsrtsrc.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ext/srt/gstsrtsink.c b/ext/srt/gstsrtsink.c index 074bd0f..bd8159d 100644 --- a/ext/srt/gstsrtsink.c +++ b/ext/srt/gstsrtsink.c @@ -155,7 +155,9 @@ gst_srt_sink_start (GstBaseSink * bsink) } if (!ret) { - GST_WARNING_OBJECT (self, "Failed to open SRT: %s", error->message); + /* ensure error is posted since state change will fail */ + GST_ELEMENT_ERROR (self, RESOURCE, OPEN_WRITE, (NULL), + ("Failed to open SRT: %s", error->message)); g_clear_error (&error); } diff --git a/ext/srt/gstsrtsrc.c b/ext/srt/gstsrtsrc.c index cfaa7ba..73392b4 100644 --- a/ext/srt/gstsrtsrc.c +++ b/ext/srt/gstsrtsrc.c @@ -114,7 +114,9 @@ gst_srt_src_start (GstBaseSrc * bsrc) } if (!ret) { - GST_WARNING_OBJECT (self, "Failed to open SRT: %s", error->message); + /* ensure error is posted since state change will fail */ + GST_ELEMENT_ERROR (self, RESOURCE, OPEN_READ, (NULL), + ("Failed to open SRT: %s", error->message)); g_clear_error (&error); } -- 2.7.4