From 269598a2cfa147b4d8361789356aba8318bde434 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C3=98yvind=20Kol=C3=A5s?= Date: Wed, 8 Apr 2009 18:18:31 +0100 Subject: [PATCH] [group] avoid double evaluation of arguments in clutter_group_add clutter_group_add would evaluate the actor argument twice, which is bad if this is a function call creating a new actor and not a variable. --- clutter/clutter-group.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clutter/clutter-group.h b/clutter/clutter-group.h index 774fc09..99a3749 100644 --- a/clutter/clutter-group.h +++ b/clutter/clutter-group.h @@ -106,10 +106,10 @@ void clutter_group_remove_all (ClutterGroup *group); /* for Mr. Mallum */ #define clutter_group_add(group,actor) G_STMT_START { \ - if (CLUTTER_IS_GROUP ((group)) && CLUTTER_IS_ACTOR ((actor))) \ + ClutterActor *_actor = (ClutterActor *) (actor); \ + if (CLUTTER_IS_GROUP ((group)) && CLUTTER_IS_ACTOR ((_actor))) \ { \ ClutterContainer *_container = (ClutterContainer *) (group); \ - ClutterActor *_actor = (ClutterActor *) (actor); \ clutter_container_add_actor (_container, _actor); \ } } G_STMT_END -- 2.7.4