From 2639fbdb7fa8894eb1c1a0c0f0ddde3e4d2c95b0 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Mon, 7 Mar 2016 14:48:38 +0100 Subject: [PATCH] rtspclientsink: Check return value of sscanf And just make sure we always have 0/0 if we have an error CID #1352031 --- gst/rtsp-sink/gstrtspclientsink.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/gst/rtsp-sink/gstrtspclientsink.c b/gst/rtsp-sink/gstrtspclientsink.c index 63cdbc3..cc3aa96 100644 --- a/gst/rtsp-sink/gstrtspclientsink.c +++ b/gst/rtsp-sink/gstrtspclientsink.c @@ -1345,11 +1345,9 @@ gst_rtsp_client_sink_set_property (GObject * object, guint prop_id, const gchar *str; str = g_value_get_string (value); - if (str) { - sscanf (str, "%u-%u", - &rtsp_client_sink->client_port_range.min, - &rtsp_client_sink->client_port_range.max); - } else { + if (!str || !sscanf (str, "%u-%u", + &rtsp_client_sink->client_port_range.min, + &rtsp_client_sink->client_port_range.max)) { rtsp_client_sink->client_port_range.min = 0; rtsp_client_sink->client_port_range.max = 0; } -- 2.7.4