From 25e687965fdc380b722712b45716ce1a6db79e3b Mon Sep 17 00:00:00 2001 From: mstarzinger Date: Wed, 17 Jun 2015 04:29:53 -0700 Subject: [PATCH] [turbofan] Remove hack for dead nodes from JSGenericLowering. Now that the graph is being trimmed after generic lowering, we can drop this workaround. The diamond will no longer confuse the scheduler. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1191913002 Cr-Commit-Position: refs/heads/master@{#29081} --- src/compiler/js-generic-lowering.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc index 851be49..60df598 100644 --- a/src/compiler/js-generic-lowering.cc +++ b/src/compiler/js-generic-lowering.cc @@ -196,9 +196,6 @@ void JSGenericLowering::ReplaceWithCompareIC(Node* node, Token::Value token) { // Finally patch the original node to select a boolean. NodeProperties::ReplaceUses(node, node, compare, compare, compare); - // TODO(mstarzinger): Just a work-around because SelectLowering might - // otherwise introduce a Phi without any uses, making Scheduler unhappy. - if (node->UseCount() == 0) return; node->TrimInputCount(3); node->ReplaceInput(0, booleanize); node->ReplaceInput(1, true_value); -- 2.7.4