From 25ae5eef33858fdae1be546fbe9cdaccd27f85e6 Mon Sep 17 00:00:00 2001 From: "robertphillips@google.com" Date: Tue, 8 Oct 2013 15:40:49 +0000 Subject: [PATCH] Fix memory leak in SkPDFRasterizer https://codereview.chromium.org/26373005/ git-svn-id: http://skia.googlecode.com/svn/trunk@11652 2bbb7eff-a529-9590-31e7-b0007b416f81 --- src/utils/SkPDFRasterizer.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/utils/SkPDFRasterizer.cpp b/src/utils/SkPDFRasterizer.cpp index 3fd2728..bf0ab25 100644 --- a/src/utils/SkPDFRasterizer.cpp +++ b/src/utils/SkPDFRasterizer.cpp @@ -21,11 +21,11 @@ bool SkPopplerRasterizePDF(SkStream* pdf, SkBitmap* output) { size_t size = pdf->getLength(); - void* buffer = sk_malloc_throw(size); - pdf->read(buffer, size); + SkAutoFree buffer(sk_malloc_throw(size)); + pdf->read(buffer.get(), size); SkAutoTDelete doc( - poppler::document::load_from_raw_data((const char*)buffer, size)); + poppler::document::load_from_raw_data((const char*)buffer.get(), size)); if (!doc.get() || doc->is_locked()) { return false; } @@ -45,7 +45,7 @@ bool SkPopplerRasterizePDF(SkStream* pdf, SkBitmap* output) { SkBitmap bitmap; bitmap.setConfig(SkBitmap::kARGB_8888_Config, width, height); if (!bitmap.allocPixels()) { - return false; + return false; } bitmap.eraseColor(SK_ColorWHITE); SkPMColor* bitmapPixels = (SkPMColor*)bitmap.getPixels(); -- 2.7.4