From 25acbf3e5080c688f413240a4c128d33e0f9ce02 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Sat, 7 Jan 2023 01:07:20 +0000 Subject: [PATCH] Apply clang-tidy fixes for llvm-qualified-auto in ModuleImport.cpp (NFC) --- mlir/lib/Target/LLVMIR/ModuleImport.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/mlir/lib/Target/LLVMIR/ModuleImport.cpp b/mlir/lib/Target/LLVMIR/ModuleImport.cpp index ac828e7..f8970b6 100644 --- a/mlir/lib/Target/LLVMIR/ModuleImport.cpp +++ b/mlir/lib/Target/LLVMIR/ModuleImport.cpp @@ -388,7 +388,7 @@ LogicalResult ModuleImport::processTBAAMetadata(const llvm::MDNode *node) { if (node->getNumOperands() != 1) return std::nullopt; // If the operand is MDString, then assume that this is a root node. - if (auto op0 = dyn_cast(node->getOperand(0))) + if (const auto *op0 = dyn_cast(node->getOperand(0))) return op0->getString(); return std::nullopt; }; @@ -414,7 +414,8 @@ LogicalResult ModuleImport::processTBAAMetadata(const llvm::MDNode *node) { // TODO: support "new" format (D41501) for type descriptors, // where the first operand is an MDNode. - auto identityNode = dyn_cast(node->getOperand(0)); + const auto *identityNode = + dyn_cast(node->getOperand(0)); if (!identityNode) return std::nullopt; @@ -480,9 +481,9 @@ LogicalResult ModuleImport::processTBAAMetadata(const llvm::MDNode *node) { unsigned numOperands = node->getNumOperands(); if (numOperands != 3 && numOperands != 4) return std::nullopt; - auto baseMD = dyn_cast(node->getOperand(0)); - auto accessMD = dyn_cast(node->getOperand(1)); - auto offsetCI = + const auto *baseMD = dyn_cast(node->getOperand(0)); + const auto *accessMD = dyn_cast(node->getOperand(1)); + auto *offsetCI = llvm::mdconst::dyn_extract(node->getOperand(2)); if (!baseMD || !accessMD || !offsetCI) return std::nullopt; @@ -496,7 +497,7 @@ LogicalResult ModuleImport::processTBAAMetadata(const llvm::MDNode *node) { return std::nullopt; bool isConst = false; if (numOperands == 4) { - auto isConstantCI = + auto *isConstantCI = llvm::mdconst::dyn_extract(node->getOperand(3)); if (!isConstantCI) { emitError(loc) << "operand '3' must be ConstantInt: " -- 2.7.4