From 256d406c73b7fc99f794a003e129fe26b0e540a7 Mon Sep 17 00:00:00 2001 From: "yangguo@chromium.org" Date: Tue, 24 Jun 2014 13:58:56 +0000 Subject: [PATCH] Revert assertion change from r21933 in Isolate::RunMicrotasks(). R=marja@chromium.org Review URL: https://codereview.chromium.org/357453002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21971 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/isolate.cc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/isolate.cc b/src/isolate.cc index 89052139d..9a850f659 100644 --- a/src/isolate.cc +++ b/src/isolate.cc @@ -2292,10 +2292,12 @@ void Isolate::EnqueueMicrotask(Handle microtask) { void Isolate::RunMicrotasks() { - // In some mjsunit tests %RunMicrotasks is called explicitly, violating - // this assertion. Therefore we also check for --allow-natives-syntax. - ASSERT(FLAG_allow_natives_syntax || - handle_scope_implementer()->CallDepthIsZero()); + // %RunMicrotasks may be called in mjsunit tests, which violates + // this assertion, hence the check for --allow-natives-syntax. + // TODO(adamk): However, this also fails some layout tests. + // + // ASSERT(FLAG_allow_natives_syntax || + // handle_scope_implementer()->CallDepthIsZero()); // Increase call depth to prevent recursive callbacks. v8::Isolate::SuppressMicrotaskExecutionScope suppress( -- 2.34.1