From 255cd4facec11b770660d357edcdeb29c8f7d7f1 Mon Sep 17 00:00:00 2001 From: "arv@chromium.org" Date: Wed, 4 Jul 2012 00:47:01 +0000 Subject: [PATCH] [V8] Remove enableFasterDOMStoreAccess which is never used https://bugs.webkit.org/show_bug.cgi?id=90489 Reviewed by Adam Barth. Source/WebCore: No new tests. Dead code removal. * bindings/v8/V8DOMMap.cpp: * bindings/v8/V8DOMMap.h: (WebCore): Source/WebKit/chromium: * src/WebScriptController.cpp: (WebKit::WebScriptController::enableV8SingleThreadMode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121818 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 13 +++++++++++++ Source/WebCore/bindings/v8/V8DOMMap.cpp | 4 ---- Source/WebCore/bindings/v8/V8DOMMap.h | 1 - Source/WebKit/chromium/ChangeLog | 10 ++++++++++ Source/WebKit/chromium/src/WebScriptController.cpp | 2 +- 5 files changed, 24 insertions(+), 6 deletions(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 84c9c0b..582779d 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,16 @@ +2012-07-03 Erik Arvidsson + + [V8] Remove enableFasterDOMStoreAccess which is never used + https://bugs.webkit.org/show_bug.cgi?id=90489 + + Reviewed by Adam Barth. + + No new tests. Dead code removal. + + * bindings/v8/V8DOMMap.cpp: + * bindings/v8/V8DOMMap.h: + (WebCore): + 2012-07-03 Joshua Bell Binding: IDL type DOMString[] shouldn't match null diff --git a/Source/WebCore/bindings/v8/V8DOMMap.cpp b/Source/WebCore/bindings/v8/V8DOMMap.cpp index f09a4a8..0b10cb0 100644 --- a/Source/WebCore/bindings/v8/V8DOMMap.cpp +++ b/Source/WebCore/bindings/v8/V8DOMMap.cpp @@ -50,10 +50,6 @@ DOMDataStoreHandle::~DOMDataStoreHandle() V8BindingPerIsolateData::current()->unregisterDOMDataStore(m_store.get()); } -void enableFasterDOMStoreAccess() -{ -} - DOMNodeMapping& getDOMNodeMap(v8::Isolate* isolate) { return DOMData::getCurrentStore(isolate).domNodeMap(); diff --git a/Source/WebCore/bindings/v8/V8DOMMap.h b/Source/WebCore/bindings/v8/V8DOMMap.h index 531d07d..4ee6c31 100644 --- a/Source/WebCore/bindings/v8/V8DOMMap.h +++ b/Source/WebCore/bindings/v8/V8DOMMap.h @@ -177,7 +177,6 @@ namespace WebCore { // This should be called to remove all DOM objects associated with the current thread when it is tearing down. void removeAllDOMObjects(); - void enableFasterDOMStoreAccess(); } // namespace WebCore #endif // V8DOMMap_h diff --git a/Source/WebKit/chromium/ChangeLog b/Source/WebKit/chromium/ChangeLog index 3b1a05d..3a5f3cd 100644 --- a/Source/WebKit/chromium/ChangeLog +++ b/Source/WebKit/chromium/ChangeLog @@ -1,3 +1,13 @@ +2012-07-03 Erik Arvidsson + + [V8] Remove enableFasterDOMStoreAccess which is never used + https://bugs.webkit.org/show_bug.cgi?id=90489 + + Reviewed by Adam Barth. + + * src/WebScriptController.cpp: + (WebKit::WebScriptController::enableV8SingleThreadMode): + 2012-07-03 Tony Chang [chromium] Unreviewed, update .gitignore to handle VS2010 files. diff --git a/Source/WebKit/chromium/src/WebScriptController.cpp b/Source/WebKit/chromium/src/WebScriptController.cpp index 948da1a..5d36bbe 100644 --- a/Source/WebKit/chromium/src/WebScriptController.cpp +++ b/Source/WebKit/chromium/src/WebScriptController.cpp @@ -48,7 +48,7 @@ void WebScriptController::registerExtension(v8::Extension* extension) void WebScriptController::enableV8SingleThreadMode() { - enableFasterDOMStoreAccess(); + // FIXME: remove this method after all it's usages are gone. } void WebScriptController::flushConsoleMessages() -- 2.7.4