From 2550cca05c6b7a0f2a72a73549c6bc8f1edc4cbc Mon Sep 17 00:00:00 2001 From: Marek Szyprowski Date: Fri, 27 Sep 2024 13:17:24 +0200 Subject: [PATCH] gpu: drm: img: fix potential NULL pointer dereference Signed-off-by: Marek Szyprowski Change-Id: I40d03860acef21452fa83b00215868bbd1391caa --- drivers/gpu/drm/img-rogue/module_common.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/img-rogue/module_common.c b/drivers/gpu/drm/img-rogue/module_common.c index 1f454c91fdb0..0dbee2b4c651 100644 --- a/drivers/gpu/drm/img-rogue/module_common.c +++ b/drivers/gpu/drm/img-rogue/module_common.c @@ -169,13 +169,22 @@ CONNECTION_DATA *LinuxSyncConnectionFromFile(struct file *pFile) if (pFile) { struct drm_file *psDRMFile = pFile->private_data; - PVRSRV_CONNECTION_PRIV *psConnectionPriv = (PVRSRV_CONNECTION_PRIV*)psDRMFile->driver_priv; + if (psDRMFile) { + PVRSRV_CONNECTION_PRIV *psConnectionPriv = (PVRSRV_CONNECTION_PRIV*)psDRMFile->driver_priv; + + if (psConnectionPriv) { #if (PVRSRV_DEVICE_INIT_MODE == PVRSRV_LINUX_DEV_INIT_ON_CONNECT) - return (CONNECTION_DATA*)psConnectionPriv->pvConnectionData; + return (CONNECTION_DATA*)psConnectionPriv->pvConnectionData; #else - return (CONNECTION_DATA*)psConnectionPriv->pvSyncConnectionData; + return (CONNECTION_DATA*)psConnectionPriv->pvSyncConnectionData; #endif + } else { + return NULL; + } + } else { + return NULL; + } } return NULL; -- 2.34.1