From 24c74f5e8c2cf263dd84292ca5d33ee0890b48dd Mon Sep 17 00:00:00 2001 From: Raphael Isemann Date: Mon, 17 Aug 2020 11:03:36 +0200 Subject: [PATCH] [lldb] Don't delete orphaned shared modules in SBDebugger::DeleteTarget In D83876 the consensus seems that LLDB should never deleted orphaned modules implicitly. However, SBDebugger::DeleteTarget is currently doing exactly that. This code was added in 753406221b55b95141c8c1239660dc4db4e35ea5 but I don't see any explanation in the commit, so I think we should delete it. Reviewed By: clayborg Differential Revision: https://reviews.llvm.org/D83933 --- lldb/source/API/SBDebugger.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/lldb/source/API/SBDebugger.cpp b/lldb/source/API/SBDebugger.cpp index 5f62987..b39481c 100644 --- a/lldb/source/API/SBDebugger.cpp +++ b/lldb/source/API/SBDebugger.cpp @@ -879,8 +879,6 @@ bool SBDebugger::DeleteTarget(lldb::SBTarget &target) { result = m_opaque_sp->GetTargetList().DeleteTarget(target_sp); target_sp->Destroy(); target.Clear(); - const bool mandatory = true; - ModuleList::RemoveOrphanSharedModules(mandatory); } } -- 2.7.4